Skip to content

Modify vcpkg_fixup_cmake_targets()#5459

Merged
vicroms merged 35 commits intomasterfrom
dev/viromer-clean/4782
Mar 1, 2019
Merged

Modify vcpkg_fixup_cmake_targets()#5459
vicroms merged 35 commits intomasterfrom
dev/viromer-clean/4782

Conversation

@vicroms
Copy link
Member

@vicroms vicroms commented Feb 26, 2019

This PR includes the changes in #4782 by @Neumann-A.
And also fixes regressions in several ports caused by these changes.

Neumann-A and others added 27 commits November 21, 2018 10:00
instead of <PackageName>Targets.cmake.
Those file also need the fix of #1044

should close #4753
hopefully solved the issue within #4150
replaced the regex with something more readable
(also ident is lost)

should close:
#4753
#4633
#4150
and maybe more
@vicroms
Copy link
Member Author

vicroms commented Mar 1, 2019

Looks like all regressions have been ironed out.

@vicroms vicroms merged commit 8641dfd into master Mar 1, 2019
This was referenced Mar 1, 2019
@nartes
Copy link
Contributor

nartes commented Mar 3, 2019

  1. find_package(CURL) issue
  2. [Possible fix](https://github.com/Microsoft/vcpkg/pull/5459/files#diff-3. 0c7285f2f03bb0891a61bd603563ad4fR36)
  3. strange patching via cmake

@grdowns grdowns deleted the dev/viromer-clean/4782 branch April 30, 2019 00:39
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
* some libraries export <PackageName>LibraryDepends.cmake
instead of <PackageName>Targets.cmake.
Those file also need the fix of microsoft#1044

should close microsoft#4753

* prefered the general solution microsoft#4622.
hopefully solved the issue within microsoft#4150
replaced the regex with something more readable
(also ident is lost)

should close:
microsoft#4753
microsoft#4633
microsoft#4150
and maybe more

* Hash vcpkg_fixup_cmake_targets.cmake

* [boost] Fix use of find_package(Boost) with cache variables
[socket-io-client] Fix install

* reversed change back to use regex replace

* [glbinding] Fix _IMPORT_PREFIX depth in *-export.cmake files

* [tinyspline] Ignore warnings treated as errors

* [libevent, liblemon, libpng, smpeg2, zlib] Fix apply patches

* [libsodium] Fix apply patches

* [folly] Link correct libraries in debug and release

* [vtk] Remove unset of _IMPORT_PREFIX

* [tinyspline] Do not treat warnings as errors

* [smpeg2] Fix double* to int comparison

* [nvtt] Define value for HAVE_UNISTD_H in MacOS

* [libui] Fix MacOS X build

* [zlib] Fix download URL

* [qhull] Update to v7.2.1

* [podofo] Set value for HAVE_UNISTD_H in MacOS

* [mongo-cxx-driver,ogre,podofo,qhull] Bump CONTROL version

* [mongo-c-driver] Set _IMPORT_PREFIX

* [tmxparser] Bump CONTROL version

* [qhull,vxl] Bump CONTROL version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants