fix find_package for fftw3 and add arch features#4783
fix find_package for fftw3 and add arch features#4783Rastaban merged 7 commits intomicrosoft:masterfrom
Conversation
|
TODO: Fix target for RelWithDebInfo linking debug fftw3 libraries |
|
Hello, I'm wondering what is the status of this PR? I have updated this PR to resolve conflicts with master at seanwarren@f0c79e7 . @Neumann-A Should I create a new PR or would you like to incorporate these changes? |
|
waiting for #5459 until I rebase and force push this branch. The conflicts should be gone then. |
…ngs of these targets instead!
…Visual Studio 2017 (maybe fixed with 2019?)
|
AVX/AVX2 ICE related VS Community Feedback would be nice if someone can tell me what exactly is failing |
|
Here is the test result. Here are all of the failures logs: |
|
Having sse2 as a default for x86 and x64 seems desirable. Is there a syntax to conditionally deactivate features by arch? I thought i saw something in a portfile once for uwp targets but it is not mentioned in the feature docs |
|
Currently there is no standard way to conditionally deactivate a feature by arch. Do you feel like having sse2 as default for x86/x64 is a precondition for having this PR merged? If not then am interested in getting this merged and adding an issue for "conditionally deactivate port features for arch that don't support them" and point to this port as a place that would benefit. |
@Rastaban: No just a nice to have feature :) |
requires: #4782
closes: #3552