Skip to content

fix find_package for fftw3 and add arch features#4783

Merged
Rastaban merged 7 commits intomicrosoft:masterfrom
Neumann-A:fftw3-fix
Mar 14, 2019
Merged

fix find_package for fftw3 and add arch features#4783
Rastaban merged 7 commits intomicrosoft:masterfrom
Neumann-A:fftw3-fix

Conversation

@Neumann-A
Copy link
Contributor

requires: #4782
closes: #3552

@Neumann-A
Copy link
Contributor Author

TODO: Fix target for RelWithDebInfo linking debug fftw3 libraries

@seanwarren
Copy link
Contributor

Hello, I'm wondering what is the status of this PR?

I have updated this PR to resolve conflicts with master at seanwarren@f0c79e7 .

@Neumann-A Should I create a new PR or would you like to incorporate these changes?

@Neumann-A
Copy link
Contributor Author

waiting for #5459 until I rebase and force push this branch. The conflicts should be gone then.
I will also remove the last commit because there is a different way to map those in the consuming project, e.g.:

set(CMAKE_MAP_IMPORTED_CONFIG_MINSIZEREL Release)
set(CMAKE_MAP_IMPORTED_CONFIG_RELWITHDEBINFO Release)

@Neumann-A
Copy link
Contributor Author

AVX/AVX2 ICE related VS Community Feedback

would be nice if someone can tell me what exactly is failing

@Cheney-W
Copy link
Contributor

Cheney-W commented Mar 6, 2019

Here is the test result.

Processing arm64-windows                  465 vs 466
     fftw3                         **regression**                Fail vs Pass

Here are all of the failures logs:
fftw3.zip

@Neumann-A
Copy link
Contributor Author

Having sse2 as a default for x86 and x64 seems desirable. Is there a syntax to conditionally deactivate features by arch? I thought i saw something in a portfile once for uwp targets but it is not mentioned in the feature docs

@Neumann-A Neumann-A changed the title fix find_package for fftw3 fix find_package for fftw3 and add arch features Mar 6, 2019
@Rastaban
Copy link
Contributor

Currently there is no standard way to conditionally deactivate a feature by arch. Do you feel like having sse2 as default for x86/x64 is a precondition for having this PR merged? If not then am interested in getting this merged and adding an issue for "conditionally deactivate port features for arch that don't support them" and point to this port as a place that would benefit.

@Rastaban Rastaban self-assigned this Mar 14, 2019
@Neumann-A
Copy link
Contributor Author

Do you feel like having sse2 as default for x86/x64 is a precondition for having this PR merged?

@Rastaban: No just a nice to have feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake cannot find FFTW package

4 participants