Skip to content

szip#518

Merged
alexkaratarakis merged 2 commits intomicrosoft:masterfrom
albertziegenhagel:szip
Jan 13, 2017
Merged

szip#518
alexkaratarakis merged 2 commits intomicrosoft:masterfrom
albertziegenhagel:szip

Conversation

@albertziegenhagel
Copy link
Contributor

@albertziegenhagel albertziegenhagel mentioned this pull request Jan 11, 2017
@msftgits
Copy link

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@alexkaratarakis
Copy link
Contributor

The dynamic build ends up with two lib files (libszip.lib and szip.lib) but only one dll. I think the libszip.lib is the static flavor of the library, and thus should be removed. The static build looks good.

Is there an option to make the CMake script not build the static flavor at all in the dynamic build?
If not, then you could simply do:

if(VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
    file(REMOVE ${CURRENT_PACKAGES_DIR}/lib/libszip.lib ${CURRENT_PACKAGES_DIR}/debug/lib/libszip_D.lib)
endif()

@albertziegenhagel
Copy link
Contributor Author

I added a patch to disable the static library in shared builds.

Just deleting the file keeps a reference to it in the szip-targets-*.cmake files and therefore makes them invalid.

@alexkaratarakis alexkaratarakis merged commit b9b1c3f into microsoft:master Jan 13, 2017
@alexkaratarakis
Copy link
Contributor

Good catch!
Merging, thanks for the PR!

@albertziegenhagel albertziegenhagel deleted the szip branch August 10, 2017 21:40
@danielaparker danielaparker mentioned this pull request Jun 11, 2024
7 tasks
BillyONeal pushed a commit that referenced this pull request Jun 11, 2024
Fixes danielaparker/jsoncons #519 
Fixes danielaparker/jsoncons #509
Fixes danielaparker/jsoncons #520 
Fixes danielaparker/jsoncons #521 
Fixes danielaparker/jsoncons #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SZip

4 participants