Merged
Conversation
Merged
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Contributor
|
The dynamic build ends up with two lib files (libszip.lib and szip.lib) but only one dll. I think the libszip.lib is the static flavor of the library, and thus should be removed. The static build looks good. Is there an option to make the CMake script not build the static flavor at all in the dynamic build? |
Contributor
Author
|
I added a patch to disable the static library in shared builds. Just deleting the file keeps a reference to it in the szip-targets-*.cmake files and therefore makes them invalid. |
Contributor
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a port for Szip (https://support.hdfgroup.org/doc_resource/SZIP/)
fixes #428