Skip to content

[jsoncons] Update to 0.176.0#39211

Merged
BillyONeal merged 13 commits intomicrosoft:masterfrom
danielaparker:master
Jun 11, 2024
Merged

[jsoncons] Update to 0.176.0#39211
BillyONeal merged 13 commits intomicrosoft:masterfrom
danielaparker:master

Conversation

@danielaparker
Copy link
Contributor

@danielaparker danielaparker commented Jun 11, 2024

Fixes danielaparker/jsoncons #519
Fixes danielaparker/jsoncons #509
Fixes danielaparker/jsoncons #520
Fixes danielaparker/jsoncons #521
Fixes danielaparker/jsoncons #518

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W self-assigned this Jun 11, 2024
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jun 11, 2024
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 11, 2024
@Cheney-W
Copy link
Contributor

@danielaparker
I don't understand why these comments need to be added. Are they really what you were expecting?

Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/519
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/509
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/520
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/521
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/518

@danielaparker
Copy link
Contributor Author

@danielaparker I don't understand why these comments need to be added. Are they really what you were expecting?

Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/519
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/509
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/520
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/521
Fixes danielaparker/jsoncons https://github.com/microsoft/vcpkg/pull/518

@Cheney-W, I was just trying to follow instructions with the pr to add any issues that this pr fixed, I've always done that. I don't know why it's substituting "https://github.com/microsoft/vcpkg/pull/" for my project. I don't think it did that before.

Obviously in this form the comments don't make sense.

@dg0yt
Copy link
Contributor

dg0yt commented Jun 11, 2024

I don't know why it's substituting "https://github.com/microsoft/vcpkg/pull/" for my project.

There was a stray before #.
But a vcpkg PR "fixing" another repo's PRs didn't look right, and your repo should document the fixed issues anyways.

@BillyONeal BillyONeal merged commit 7f76810 into microsoft:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants