-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[lib3mf] update to 2.5.0 #50158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[lib3mf] update to 2.5.0 #50158
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bc95491
Prepare for lib3mf 2.5.0 release on vcpkg
vijaiaeroastro 61a248c
Merge branch 'microsoft:master' into master
vijaiaeroastro dba91f3
Cleaned up lib3mf port according to guidelines
vijaiaeroastro ce5ab1f
Merge branch 'master' of github.com:3MFConsortium/vcpkg
vijaiaeroastro 988a749
Merge branch 'microsoft:master' into master
vijaiaeroastro 0192bcb
Update lib3mf port based on PR comments
vijaiaeroastro eddcd12
Update current version of lib3mf port
vijaiaeroastro 5e0801c
Apply suggestions from code review
vijaiaeroastro 7e507b8
Remove the unnecessary checks for package dir
vijaiaeroastro 420bcaf
Update version hash
vijaiaeroastro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| diff --git a/cmake/lib3mfConfig.cmake.in b/cmake/lib3mfConfig.cmake.in | ||
| index 589422b3..c8f05f44 100644 | ||
| --- a/cmake/lib3mfConfig.cmake.in | ||
| +++ b/cmake/lib3mfConfig.cmake.in | ||
| @@ -23,8 +23,14 @@ if(NOT TARGET lib3mf::lib3mf) | ||
| return() | ||
| endif() | ||
|
|
||
| get_filename_component(_lib3mf_package_dir "${CMAKE_CURRENT_LIST_DIR}" ABSOLUTE) | ||
| -get_filename_component(LIB3MF_ROOT_DIR "${_lib3mf_package_dir}/../../.." ABSOLUTE) | ||
| +get_filename_component(_lib3mf_root_guess "${_lib3mf_package_dir}/../.." ABSOLUTE) | ||
| +if(EXISTS "${_lib3mf_root_guess}/include/Bindings") | ||
| + set(LIB3MF_ROOT_DIR "${_lib3mf_root_guess}") | ||
| +else() | ||
| + get_filename_component(LIB3MF_ROOT_DIR "${_lib3mf_package_dir}/../../.." ABSOLUTE) | ||
| +endif() | ||
| + | ||
| set(LIB3MF_CDYNAMIC_ADDITIONAL_SOURCE "${LIB3MF_ROOT_DIR}/include/Bindings/CDynamic/lib3mf_dynamic.cc") | ||
|
|
||
| set(_lib3mf_library_location_definition "LIB3MF_LIBRARY_LOCATION=\"$<TARGET_FILE:lib3mf::lib3mf>\"") | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.