[lib3mf] update to 2.5.0#50158
Merged
Merged
Conversation
JavierMatosD
suggested changes
Feb 25, 2026
dg0yt
reviewed
Feb 25, 2026
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Contributor
Author
|
@JavierMatosD Could you please check the PR again ? I have addressed all of the comments / suggestions. |
JavierMatosD
approved these changes
Feb 25, 2026
Contributor
|
@vijaiaeroastro everything looks good! Thank you for the contribution! |
dg0yt
reviewed
Feb 26, 2026
| PATCHES | ||
| lib3mf_vcpkg.patch | ||
| fix-lib3mf-config-root.patch | ||
| fix-dependency-resolution-required.patch |
Contributor
There was a problem hiding this comment.
This patch is unnecessary...
(Hint: There is CMAKE_REQUIRE_FIND_PACKAGE/VCPKG_LOCK_FIND_PACKAGE.)
Contributor
Author
There was a problem hiding this comment.
@dg0yt Thanks. Will keep it in mind for next release.
Contributor
There was a problem hiding this comment.
It is a frequent vcpkg pattern. Maintainers should be aware. Now it is forever in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR updates an existing port, please uncomment and fill out this checklist:
./vcpkg x-add-version --alland committing the result.