[yoctolib] 2.1.11761 Update

[yoctopuce]

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[srinsoz]

@microsoft-github-policy-service agree company="Yoctopuce"

[nickdademo]

Nice :) Linux job failure is due to the libusb include, looks like this patch change was not applied upstream:

-#include <libusb-1.0/libusb.h>
+#include <libusb.h>

[nickdademo]

this needs to be changed to instead install the copyright file that was added in this PR

[srinsoz]

done

[srinsoz]

Nice :) Linux job failure is due to the libusb include, looks like this patch change was not applied upstream:

-#include <libusb-1.0/libusb.h>
+#include <libusb.h>

I noticed that the previous port was handling this, but in my opinion, this approach is incorrect.
On all the Linux machines I’ve tested, you need to include <libusb-1.0/libusb.h>.

[dg0yt]

On all the Linux machines I’ve tested, you need to include <libusb-1.0/libusb.h>.

libusb.pc (in vcpkg and Debian) has Cflags: "-I${includedir}/libusb-1.0", and the files is in ${includedir}/libusb-1.0/libusb.h. So only <libusb.h> would match the official pkgconfig file.

[dg0yt]

AFAICT copyright files shall not be added to the vcpkg repo.

[srinsoz]

I followed the official documentation (https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#license) and used the strtk package (https://github.com/microsoft/vcpkg/tree/master/ports/strtk) as a reference for implementation.
However, if needed, I can revert to the previous version and simply copy the README.md from our library.

[BillyONeal]

We usually require that the license come out of the actual upstream repo rather than trying to cough up the text ourselves so that updates that change the license don't end up making us install lies about what the license is.

[dg0yt]

I followed the official documentation (https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#license) and used the strtk package (https://github.com/microsoft/vcpkg/tree/master/ports/strtk) as a reference for implementation.

The documentation is not for the copyright file but for the license manifest field.
strtk is an old port with few updates.

But there is this: https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#install-copyright-file

In some ports, we use regex pattern matching to extract the licensing part from source files. I admit this needs some extra care during port updates.

[dg0yt]

Is there a vendored mbedtls?

[srinsoz]

On all the Linux machines I’ve tested, you need to include <libusb-1.0/libusb.h>.

libusb.pc (in vcpkg and Debian) has Cflags: "-I${includedir}/libusb-1.0", and the files is in ${includedir}/libusb-1.0/libusb.h. So only <libusb.h> would match the official pkgconfig file.

I will add a patch to fix this for vcpkg, but we are not changing our code since we never had any issue with this include

[yoctopuce]

@microsoft-github-policy-service agree company="Yoctopuce"

[BillyONeal]

yoctopuce#1

[BillyONeal]

We usually require that the license come out of the actual upstream repo rather than trying to cough up the text ourselves so that updates that change the license don't end up making us install lies about what the license is.

[dg0yt]

I will add a patch to fix this for vcpkg, but we are not changing our code since we never had any issue with this include

I don't know the extent for "never" here. The current approach would typically include the "right" header in native builds, due to typical installation layouts. It might also often include the "wrong" header in cross builds without the user noticing, subject to sysroot and default search paths. IMHO it is simply wrong to use pkgconfig while not using the paths provided by pkgconfig.

FTR here is a code example from official documentation:
https://libusb.sourceforge.io/api-1.0/libusb_hotplug.html

[BillyONeal]

❤️

[dg0yt]

Repeating my question:

Is there a vendored mbedtls?

[nickdademo]

Repeating my question:

Is there a vendored mbedtls?

I investigated de-vendoring when I created this port a few months back. Didn't seem possible...
Ref: #48871 (comment)

[dg0yt]

So it is not used? (But it is also not removed.)

[nickdademo]

So it is not used? (But it is also not removed.)

Not used. Portfile sets USE_YSSL=OFF

https://github.com/yoctopuce/yoctolib_cpp/blob/master/Sources/yapi/CMakeLists.txt#L7