[yoctolib] new port#48871
Conversation
dg0yt
left a comment
There was a problem hiding this comment.
Please use LF line endings.
|
Note: Removed Android support in this port as vendor has a different lib for that: https://github.com/yoctopuce/yoctolib_android |
|
@dg0yt Are you able to take another look? (before I try and de-vendor |
dg0yt
left a comment
There was a problem hiding this comment.
A few more nitpicks. But LGTM.
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for the new port!
@dg0yt Thanks for the review!
|
Hi, we’ve just discovered the existence of this vcpkg package and noticed that it is already outdated. How can we contribute to keeping this package up to date? |
@srinsoz Ah, looks like you've published releases since I created this port - nice :) Updating the port should just be a matter of bumping the relevant version and hash. However, you'll notice that 3 patches are applied to your source - definitely would be nice if these changes were made upstream on your end ;) (especially the exporting of a CMake config). |
|
So, if I understand correctly, to keep this package up to date with our releases, we need to create a pull request in this repository with the updated |
Update |
Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, allfind_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.