Skip to content

[yoctolib] new port#48871

Merged
BillyONeal merged 25 commits into
microsoft:masterfrom
nickdademo:yoctolib_new_port
Dec 15, 2025
Merged

[yoctolib] new port#48871
BillyONeal merged 25 commits into
microsoft:masterfrom
nickdademo:yoctolib_new_port

Conversation

@nickdademo
Copy link
Copy Markdown
Contributor

@nickdademo nickdademo commented Dec 14, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use LF line endings.

Comment thread ports/yoctolib/001-cmake_config.patch Outdated
Comment thread ports/yoctolib/001-cmake_config.patch Outdated
Comment thread ports/yoctolib/001-cmake_config.patch Outdated
Comment thread ports/yoctolib/002-add_missing_win32_bcrypt_linkage.patch Outdated
Comment thread ports/yoctolib/003-fix_win32_shared_build.patch Outdated
Comment thread ports/yoctolib/004-fix_cmake_proj_version.patch Outdated
Comment thread ports/yoctolib/005-find_linux_depends.patch Outdated
Comment thread ports/yoctolib/portfile.cmake Outdated
Comment thread ports/yoctolib/portfile.cmake Outdated
Comment thread ports/yoctolib/vcpkg.json Outdated
@nickdademo nickdademo marked this pull request as draft December 14, 2025 09:03
@nickdademo
Copy link
Copy Markdown
Contributor Author

Note: Removed Android support in this port as vendor has a different lib for that: https://github.com/yoctopuce/yoctolib_android

@nickdademo
Copy link
Copy Markdown
Contributor Author

@dg0yt Are you able to take another look? (before I try and de-vendor mbedtls)

@nickdademo nickdademo marked this pull request as ready for review December 15, 2025 05:43
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nitpicks. But LGTM.

Comment thread ports/yoctolib/001-cmake_config.patch Outdated
Comment thread ports/yoctolib/portfile.cmake Outdated
Comment thread ports/yoctolib/portfile.cmake Outdated
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port!

@dg0yt Thanks for the review!

@BillyONeal BillyONeal merged commit e40cbcc into microsoft:master Dec 15, 2025
17 checks passed
geiseri pushed a commit to geiseri/vcpkg that referenced this pull request Dec 18, 2025
@srinsoz
Copy link
Copy Markdown

srinsoz commented Feb 2, 2026

Hi, we’ve just discovered the existence of this vcpkg package and noticed that it is already outdated. How can we contribute to keeping this package up to date?

@nickdademo
Copy link
Copy Markdown
Contributor Author

Hi, we’ve just discovered the existence of this vcpkg package and noticed that it is already outdated. How can we contribute to keeping this package up to date?

@srinsoz Ah, looks like you've published releases since I created this port - nice :)

Updating the port should just be a matter of bumping the relevant version and hash. However, you'll notice that 3 patches are applied to your source - definitely would be nice if these changes were made upstream on your end ;) (especially the exporting of a CMake config).

@srinsoz
Copy link
Copy Markdown

srinsoz commented Feb 2, 2026

So, if I understand correctly, to keep this package up to date with our releases, we need to create a pull request in this repository with the updated vcpkg.json and vcpkg-configuration.json files each time we publish a new release. Is that correct?
Additionally, since we plan to officially add our library to vcpkg, should we remove the "Unofficial::" prefix?

@nickdademo
Copy link
Copy Markdown
Contributor Author

So, if I understand correctly, to keep this package up to date with our releases, we need to create a pull request in this repository with the updated vcpkg.json and vcpkg-configuration.json files each time we publish a new release. Is that correct? Additionally, since we plan to officially add our library to vcpkg, should we remove the "Unofficial::" prefix?

Update vcpkg.json and portfile.cmake. If your upstream repo provides the CMake config, then the unofficial:: prefix can be removed (as that patch would no longer be needed).

@nickdademo nickdademo mentioned this pull request Feb 6, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants