Skip to content

[supernovas] Patch for upstream issue #272. #48336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicroms merged 1 commit into from
Nov 18, 2025
Merged

[supernovas] Patch for upstream issue #272. #48336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ports/supernovas/cmake.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index d340fb28..7a4ad3ea 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -168,9 +168,6 @@ set_target_properties(core PROPERTIES
VERSION ${PROJECT_VERSION}
SOVERSION ${PROJECT_VERSION_MAJOR}
POSITION_INDEPENDENT_CODE ON
- EXPORT_NAME supernovas
- OUTPUT_NAME supernovas
- CLEAN_DIRECT_OUTPUT ON
)

target_include_directories(core PUBLIC
2 changes: 2 additions & 0 deletions ports/supernovas/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ vcpkg_from_github(
REF "v${VERSION}"
SHA512 b78e5b3e9792fbebd47064c747be675022f2758c30ac2cd69ade5601d9693b8eb8786c46c56df76f04feef963310838042833b7a91e2cc6c9317a5c34717ade8
HEAD_REF main
PATCHES
cmake.patch
)

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
Expand Down
1 change: 1 addition & 0 deletions ports/supernovas/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "supernovas",
"version": "1.5.0",
"port-version": 1,
"description": "SuperNOVAS C/C++ high-precision astrometry library",
"homepage": "https://smithsonian.github.io/SuperNOVAS/",
"documentation": "https://smithsonian.github.io/SuperNOVAS/doc/html/",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9510,7 +9510,7 @@
},
"supernovas": {
"baseline": "1.5.0",
"port-version": 0
"port-version": 1
},
"sushant-wayal-stringhash": {
"baseline": "1.1.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/s-/supernovas.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@vicroms vicroms Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of this file should be generated by the x-add-version command. Please revert the changes made to this file, then change ports/supernovas/vcpkg.json and increase port-version to 1. Then run vcpkg x-add-version supernovas.

Each PR should only add a new version and must not modify the git-tree of a previously published version.

Copy link
Copy Markdown
Contributor Author

@attipaci attipaci Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help. Did as you told. :-)

Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "e68d91b07bbfb40406e0fae9c568de50601eba8d",
"version": "1.5.0",
"port-version": 1
},
{
"git-tree": "23a370449299e68985392d80988e4fbc7b675245",
"version": "1.5.0",
Expand Down