[supernovas] Patch for upstream issue #272.#48336
Merged
vicroms merged 1 commit intomicrosoft:masterfrom Nov 18, 2025
Merged
Conversation
vicroms
requested changes
Nov 17, 2025
Member
vicroms
left a comment
vicroms
left a comment
There was a problem hiding this comment.
Please fix version database. I'm marking this PR as draft, once the changes have been implemented please mark it as Ready for Review.
Member
There was a problem hiding this comment.
The contents of this file should be generated by the x-add-version command. Please revert the changes made to this file, then change ports/supernovas/vcpkg.json and increase port-version to 1. Then run vcpkg x-add-version supernovas.
Each PR should only add a new version and must not modify the git-tree of a previously published version.
Contributor
Author
There was a problem hiding this comment.
Thanks for the help. Did as you told. :-)
attipaci
force-pushed
the
cmake-export-targets
branch
from
4ae39b4 to
181bafe
Compare
vicroms
approved these changes
Nov 18, 2025
luadebug
pushed a commit
to luadebug/vcpkg
that referenced
this pull request
Nov 21, 2025
geiseri
pushed a commit
to geiseri/vcpkg
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream
CMakeLists.txtexported the main library target with a different name than whatsupernovasConfig.cmakewas expecting (see upstream Issue #272). A patch toCMakeLists.txtshould fix this issue, until the same fix is released upstream in a couple of months..../vcpkg x-add-version --alland committing the result.