Skip to content

[vcpkg-tool-nodejs] Do not break osx code signatures #46353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicroms merged 3 commits into from
Jul 10, 2025
Merged

[vcpkg-tool-nodejs] Do not break osx code signatures #46353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a300a6
[vcpkg-tool-nodejs] Don't break nodesjs code signatures
dg0yt Jul 9, 2025
bd4748a
Add dest port
dg0yt Jul 9, 2025
129e283
Fixup
dg0yt Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ports/vcpkg-tool-nodejs/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,8 @@ vcpkg_execute_in_download_mode(
)

file(RENAME "${CURRENT_PACKAGES_DIR}/tools/${ARCHIVE}" "${CURRENT_PACKAGES_DIR}/tools/node")

# Do not break code signatures
if(VCPKG_TARGET_IS_OSX)
set(VCPKG_FIXUP_MACHO_RPATH OFF)
endif()
2 changes: 1 addition & 1 deletion ports/vcpkg-tool-nodejs/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vcpkg-tool-nodejs",
"version-semver": "16.18.0",
"port-version": 1,
"port-version": 2,
"supports": "native"
}
20 changes: 20 additions & 0 deletions scripts/test_ports/vcpkg-ci-vcpkg-tool-nodejs/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
set(VCPKG_POLICY_EMPTY_PACKAGE enabled)

find_program(NODEJS
NAMES node
PATHS
"${CURRENT_INSTALLED_DIR}/tools/node"
"${CURRENT_INSTALLED_DIR}/tools/node/bin"
NO_DEFAULT_PATH
REQUIRED
)
execute_process(
COMMAND "${NODEJS}" --version
COMMAND_ECHO STDOUT
COMMAND_ERROR_IS_FATAL ANY
)
execute_process(
COMMAND "${NODEJS}" -p "process.arch"
COMMAND_ECHO STDOUT
COMMAND_ERROR_IS_FATAL ANY
)
9 changes: 9 additions & 0 deletions scripts/test_ports/vcpkg-ci-vcpkg-tool-nodejs/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"name": "vcpkg-ci-vcpkg-tool-nodejs",
"version-string": "ci",
"description": "Test port to validate vcpkg-tool-nodejs",
"supports": "native",
"dependencies": [
"vcpkg-tool-nodejs"
]
}
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9950,7 +9950,7 @@
},
"vcpkg-tool-nodejs": {
"baseline": "16.18.0",
"port-version": 1
"port-version": 2
},
"vcpkg-tool-python2": {
"baseline": "2.7.18",
Expand Down
5 changes: 5 additions & 0 deletions versions/v-/vcpkg-tool-nodejs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "6d004b33aa9e92c31d1238728de1546712af44d0",
"version-semver": "16.18.0",
"port-version": 2
},
{
"git-tree": "2738f551c277a4ac6650e7d140fc36aa26210a63",
"version-semver": "16.18.0",
Expand Down
Loading