Skip to content

[asio] Updates asio to 1.32.4#44969

Closed
OhmV-IR wants to merge 2 commits intomicrosoft:masterfrom
OhmV-IR:update-asio-1.34.2
Closed

[asio] Updates asio to 1.32.4#44969
OhmV-IR wants to merge 2 commits intomicrosoft:masterfrom
OhmV-IR:update-asio-1.34.2

Conversation

@OhmV-IR
Copy link
Contributor

@OhmV-IR OhmV-IR commented Apr 10, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
    Packages that need to be fixed:
  • fastdds (upstream not updated for this removal, patch would be large since all the classnames would have to be changed)
  • fineftp([fineftp] Update to 1.5.1 #45025 )
  • hpx (no upstream release to fix this, again patch would be large)
  • nrf-ble-driver (archived upstream repo, no update is coming)
  • opendnp3 (archived upstream repo, no update is coming)
  • pulsar-client-cpp (upstream not updated yet for new dep)
  • restbed (uses io context in a few places, but still has some io_service usage)
  • sese (seems to be fixed on master, waiting for them to make an official release)
  • tcp-pubsub ([tcp-pubsub] Update to 2.0.1 #45028 )
  • vcpkg-ci-rest-rpc

@Mengna-Li Mengna-Li self-assigned this Apr 11, 2025
@Mengna-Li Mengna-Li changed the title Updates asio to 1.32.4 [asio] Updates asio to 1.32.4 Apr 11, 2025
@Mengna-Li Mengna-Li added the category:port-update The issue is with a library, which is requesting update new revision label Apr 11, 2025
@OhmV-IR
Copy link
Contributor Author

OhmV-IR commented Apr 11, 2025

I appear to have stepped into a bit of a problematic update: I believe this is the asio version that removes the deprecated io_service which breaks some existing packages in the system. Is there a way for me to change their vcpkg.json files to specify a version that they are dependent on? UPDATE: yep I was right
image
Looking for guidance from @Mengna-Li on how to resolve this, my first thoughts are either to delist the packages that rely on the deprecated service or to patch them to use the new io_context class name(the commit implies that all the io_service features are available within io_context, so this might not be that difficult)

@miyanyan
Copy link
Contributor

you may have to do the same thing like boost-asio, see this pr #42678

  • you can't specify a version
  • for ports that need a small patch, it's ok
  • for ports that need a large patch

    At the very least, the upstreams for all the ports that require patching for compatibility with boost-asio need to be notified. According to vcpkg policy, they should be given 30 days to respond. Once their time is up we can look at each port to determine whether we should patch it or delist the port.

@OhmV-IR
Copy link
Contributor Author

OhmV-IR commented Apr 14, 2025

you may have to do the same thing like boost-asio, see this pr #42678

  • you can't specify a version
  • for ports that need a small patch, it's ok
  • for ports that need a large patch

    At the very least, the upstreams for all the ports that require patching for compatibility with boost-asio need to be notified. According to vcpkg policy, they should be given 30 days to respond. Once their time is up we can look at each port to determine whether we should patch it or delist the port.

Okay, I've updated the PR description to show all of the packages that failed in CI and their status, of them I'd say we should contact fastdds, hpx, pulsar-client-cpp, restbed and sese. The repos for nrf-ble-driver and opendnp3 are archived, so our options there are either patch or delist. Finally, I've opened PRs to update fineftp and tcp-pubsub which have released versions to fix the issues.

@OhmV-IR OhmV-IR closed this Sep 19, 2025
@OhmV-IR OhmV-IR deleted the update-asio-1.34.2 branch December 16, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants