Skip to content

[nanojsonc] update 1.2.0#43410

Merged
JavierMatosD merged 13 commits intomicrosoft:masterfrom
saadshams:nanojsonc
May 15, 2025
Merged

[nanojsonc] update 1.2.0#43410
JavierMatosD merged 13 commits intomicrosoft:masterfrom
saadshams:nanojsonc

Conversation

@saadshams
Copy link
Contributor

@saadshams saadshams commented Jan 22, 2025

  • [x ] Changes comply with the maintainer guide.
  • [x ] SHA512s are updated for each updated download.
  • [x ] The "supports" clause reflects platforms that may be fixed by this new version.
  • [x ] Any fixed CI baseline entries are removed from that file.
  • [x ] Any patches that are no longer applied are deleted from the port's directory.
  • [x ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [x ] Only one version is added to each modified port's versions file.

@saadshams saadshams changed the title [nanojsonc] update 1.1.0 [nanojsonc] update 1.2.0 Jan 22, 2025
@saadshams
Copy link
Contributor Author

Unable to upgrade the port to 1.2.0, please support.

@LilyWangLL LilyWangLL self-assigned this Jan 23, 2025
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jan 23, 2025
@saadshams
Copy link
Contributor Author

@LilyWangLL Please guide on what's missing?

@LilyWangLL
Copy link
Contributor

Installing 3/3 nanojsonc:x64-windows@1.2.0...
Building nanojsonc:x64-windows@1.2.0...
-- Note: nanojsonc only supports static library linkage. Building static library.
Asset cache miss; downloading from https://github.com/open-source-patterns/nanojsonc/archive/1.2.0.tar.gz
Downloading open-source-patterns-nanojsonc-1.2.0.tar.gz
Failed to download open-source-patterns-nanojsonc-1.2.0.tar.gz.
If you are using a proxy, please ensure your proxy settings are correct.
Possible causes are:

  1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable to https//address:port.
    This is not correct, because https:/// prefix claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr, etc...) is an HTTP proxy.
    Try setting http://address:port/ to both HTTP_PROXY and HTTPS_PROXY instead.
  2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings set by your proxy software. See, If HTTP(S)_PROXY already exist in environment variable, do not use IE Proxy (#49) vcpkg-tool#77
    The value set by your proxy might be wrong, or have same https:/// prefix issue.
  3. Your proxy's remote server is our of service.
    If you've tried directly download the link, and believe this is not a temporay download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
    to report this upstream download server failure.
    error: https://vcpkgassetcachewus.blob.core.windows.net/cache/8fe36b742b994598d6f5ae30433245f63da5378ff6866f593cf53916e2b2fdc5d85ddc88d20908fd1166c3568f62e2a8dd837270855cb603dad88246a726be51?*** SECRET ***: failed: status code 404
    error: File does not have the expected hash:
    url: https://github.com/open-source-patterns/nanojsonc/archive/1.2.0.tar.gz
    File: D:\downloads\open-source-patterns-nanojsonc-1.2.0.tar.gz.8340.part
    Expected hash: 8fe36b742b994598d6f5ae30433245f63da5378ff6866f593cf53916e2b2fdc5d85ddc88d20908fd1166c3568f62e2a8dd837270855cb603dad88246a726be51
    Actual hash: a83f38c67222d227faf352495b174a16ff6d5a0a45e9d6eda499ca6e8978d2dba184f820c7b726d80468a11fee02460cbd8b189d69a46716bd01c46e7b0607fd

@LilyWangLL LilyWangLL marked this pull request as draft January 26, 2025 08:11
@LilyWangLL
Copy link
Contributor

Please use command .\vcpkg x-add-version nanojsonc --overwrite-version to update the version file after you commit the new changes.

Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@saadshams saadshams marked this pull request as ready for review May 13, 2025 18:28
@saadshams
Copy link
Contributor Author

@LilyWangLL I have updated SHA512 and added version programmatically after committing changes.

.\vcpkg x-add-version nanojsonc --overwrite-version

saadshams and others added 2 commits May 14, 2025 16:55
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@saadshams saadshams requested a review from LilyWangLL May 14, 2025 21:07
saadshams added 2 commits May 14, 2025 17:45
update to 1.2.0
update to 1.2.0
@LilyWangLL LilyWangLL marked this pull request as draft May 15, 2025 02:24
@LilyWangLL
Copy link
Contributor

Please try not to manually modify the versions files (versions/baseline.json and versions/n-/nanojsonc.json ). After you finish updating the port-related codes, run command .\vcpkg x-add-version nanojsonc --overwrite-version, which will automatically update the version files. For reference, see the maintainer guide: https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#versioning.

saadshams and others added 2 commits May 15, 2025 00:31
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@saadshams
Copy link
Contributor Author

saadshams commented May 15, 2025

remove supports field: OK
Leaving versions/baseline.json and versions/n-/nanojsonc.js intact.
Executed command .\vcpkg x-add-version nanojsonc --overwrite-version
Pushed the code.

@dg0yt
Copy link
Contributor

dg0yt commented May 15, 2025

Not resolved: Remove the "supports" line.

update to 1.2.0
@saadshams
Copy link
Contributor Author

Sorry. pushed the update without supports field.

@LilyWangLL LilyWangLL marked this pull request as ready for review May 15, 2025 07:05
Copy link
Contributor Author

@saadshams saadshams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. all looks good, the approve field is disabled on my side
Is there an action item for me?

@JavierMatosD JavierMatosD merged commit d7ce872 into microsoft:master May 15, 2025
18 checks passed
@saadshams
Copy link
Contributor Author

Thanks. for information, how and from where the hash for git-tree is calculated?

@LilyWangLL
Copy link
Contributor

Thanks. for information, how and from where the hash for git-tree is calculated?

You can refer to the documentation https://github.com/MicrosoftDocs/vcpkg-docs/blob/main/vcpkg/users/examples/versioning.getting-started.md#builtin-baseline.

@saadshams
Copy link
Contributor Author

Hi @LilyWangLL I mean the following git-tree values, how and from where are they generated from


{
  "versions": [
    {
      "git-tree": "41dc847f236000b8a703cf452d37ae36c39ec155",
      "version": "1.2.0",
      "port-version": 0
    },
    {
      "git-tree": "102c65ad71dc556dd82d4af6d83efd96ee316311",
      "version": "1.1.0",
      "port-version": 0
    },
    {
      "git-tree": "7680709fd527db1cc26d47f8897c0669cacbfb0f",
      "version": "1.0.0",
      "port-version": 0
    }
  ]
}

@dg0yt
Copy link
Contributor

dg0yt commented May 17, 2025

This is how it works:
https://learn.microsoft.com/en-us/vcpkg/maintainers/registries#obtain-git-tree-sha

@saadshams saadshams deleted the nanojsonc branch June 20, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants