Skip to content

[c-ares] Update to 1.33.0, fix uwp#40224

Merged
data-queue merged 1 commit intomicrosoft:masterfrom
dg0yt:c-ares
Aug 6, 2024
Merged

[c-ares] Update to 1.33.0, fix uwp#40224
data-queue merged 1 commit intomicrosoft:masterfrom
dg0yt:c-ares

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Aug 2, 2024

The uwp fix from upstream needed a small edit.
Originally c-ares/c-ares#845
Upstream reacted super-fast when noticed. It is a pity that it wasn't immediately reported with #40213.

@dg0yt dg0yt mentioned this pull request Aug 2, 2024
8 tasks
@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Aug 2, 2024
@talregev
Copy link
Copy Markdown
Contributor

talregev commented Aug 2, 2024

@dg0yt The same error happened here.

@bradh352
Copy link
Copy Markdown

bradh352 commented Aug 2, 2024

fyi, c-ares 1.33.0 is out that includes this fix

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Aug 3, 2024

So the Windows DLL triplets fail to build downstream cmake.

[527/528] C:\Windows\system32\cmd.exe /C "cd . && D:\downloads\tools\cmake-3.29.2-windows\cmake-3.29.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=Source\QtDialog\CMakeFiles\cmake-gui.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests D:\b\cmake\src\17503183d2-2d56d3dcb1.clean\Source\cmake.version.manifest -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\link.exe  Source\QtDialog\CMakeFiles\CMakeGUIQRCLib.dir\qrc_CMakeSetup.cpp.obj Source\CMakeFiles\CMakeVersion.dir\CMakeVersion.rc.res Source\QtDialog\CMakeFiles\cmake-gui.dir\CMakeGUIExec.cxx.obj Source\QtDialog\CMakeFiles\cmake-gui.dir\CMakeSetup.rc.res  /out:bin\cmake-gui.exe /implib:bin\cmake-gui.lib /pdb:bin\cmake-gui.pdb /version:0.0 /machine:x64 -stack:10000000 /nologo    /debug /INCREMENTAL /subsystem:windows  Source\QtDialog\CMakeGUIMainLib.lib  Source\QtDialog\CMakeGUILib.lib  Source\CMakeLib.lib  Source\kwsys\cmsys.lib  Utilities\std\cmstd.lib  D:\installed\x64-windows\debug\lib\libexpatd.lib  D:\installed\x64-windows\debug\lib\zlibd.lib  D:\installed\x64-windows\debug\lib\archive.lib  D:\installed\x64-windows\debug\lib\libcurl-d.lib  D:\installed\x64-windows\debug\lib\jsoncpp.lib  D:\installed\x64-windows\debug\lib\uv.lib  psapi.lib  user32.lib  advapi32.lib  iphlpapi.lib  ws2_32.lib  dbghelp.lib  ole32.lib  Utilities\cmlibrhash\cmlibrhash.lib  rpcrt4.lib  crypt32.lib  D:\installed\x64-windows\debug\lib\Qt6Widgetsd.lib  D:\installed\x64-windows\debug\lib\Qt6Guid.lib  D:\installed\x64-windows\debug\lib\Qt6Cored.lib  mpr.lib  userenv.lib  D:\installed\x64-windows\debug\lib\Qt6EntryPointd.lib  shell32.lib  d3d11.lib  dxgi.lib  dxguid.lib  d3d12.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
[527/528] C:\Windows\system32\cmd.exe /C "cd /D D:\b\cmake\x64-windows-dbg && D:\b\cmake\x64-windows-dbg\bin\cmake.exe -P cmake_install.cmake"
FAILED: CMakeFiles/install.util 
C:\Windows\system32\cmd.exe /C "cd /D D:\b\cmake\x64-windows-dbg && D:\b\cmake\x64-windows-dbg\bin\cmake.exe -P cmake_install.cmake"

The link command is executed via the installed cmake (D:\downloads\tools\cmake-3.29.2-windows\cmake-3.29.2-windows-i386\bin\cmake.exe),
but the failing install command is executed via the the freshly built cmake (D:\b\cmake\x64-windows-dbg\bin\cmake.exe).
The test port still builds cmake 3.22.2. But I'm really surprised to see it switch the binary.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Aug 3, 2024

So CMake wants it this way:
https://github.com/Kitware/CMake/blob/4aa42149d69c8e0fa542e18196463d671190710c/Source/cmGlobalGenerator.cxx#L3121-L3127

How do I find out which runtime library or Qt plugin is mismatched or missing...
(The error doesn't occur only with c-ares. It is not directly linked to this PR.)

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Aug 3, 2024

Moving the cmake baseline issue to #40253.

@dg0yt dg0yt mentioned this pull request Aug 3, 2024
@dg0yt dg0yt changed the title [c-ares] Update, backport uwp fix [c-ares] Update to 1.33.0, fix uwp Aug 4, 2024
@Neumann-A
Copy link
Copy Markdown
Contributor

How do I find out which runtime library or Qt plugin is mismatched or missing...

Qt isn't involved here. The build is not executing cmake-gui, just plain cmake.

@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 5, 2024
@talregev talregev mentioned this pull request Aug 5, 2024
7 tasks
@talregev
Copy link
Copy Markdown
Contributor

talregev commented Aug 5, 2024

@dg0yt Are you going to work on cmake port problem?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Aug 5, 2024

Are you going to work on cmake port problem?

Port cmake is no longer relevant for this PR.

@data-queue data-queue merged commit 624fe64 into microsoft:master Aug 6, 2024
@dg0yt dg0yt deleted the c-ares branch August 6, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants