Skip to content

[vcpkg baseline][c-ares] Add unsupported uwp platform#40213

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
jimwang118:fix-c-ares
Aug 1, 2024
Merged

[vcpkg baseline][c-ares] Add unsupported uwp platform#40213
BillyONeal merged 2 commits intomicrosoft:masterfrom
jimwang118:fix-c-ares

Conversation

@jimwang118
Copy link
Copy Markdown
Contributor

Failed on: https://dev.azure.com/vcpkg/public/_build/results?buildId=105429&view=results

 error C4013: 'UnregisterWait' undefined; assuming extern returning int
 error C4013: 'NotifyIpInterfaceChange' undefined; assuming extern returning int

The UnregisterWait and NotifyIpInterfaceChange functions are Win32 system functions and are not defined under UWP. Therefore, adding them does not support the UWP platform.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
x64-windows-static

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 1, 2024
@talregev
Copy link
Copy Markdown
Contributor

talregev commented Aug 1, 2024

@jimwang118 you should also change curl ci test, and move c-ares, to be platform: "!uwp"

@BillyONeal BillyONeal marked this pull request as ready for review August 1, 2024 21:30
@BillyONeal BillyONeal merged commit 09fe6ab into microsoft:master Aug 1, 2024
@BillyONeal
Copy link
Copy Markdown
Member

I merged this to unblock #40203 . Thanks for the fix!

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Aug 1, 2024

I notified upstream: c-ares/c-ares#785 (comment)

bradh352 added a commit to c-ares/c-ares that referenced this pull request Aug 1, 2024
Because AppVeyor's version of MSVC needed to be patched to build UWP
applications:
https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.

It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213

This PR fixes the build regression and also adds a GitHub action CI
workflow for building the UWP app so we can catch this in the future.

Fix By: Brad House (@bradh352)
@bradh352
Copy link
Copy Markdown

bradh352 commented Aug 1, 2024

Fixed in c-ares/c-ares@3fd5925
Should be in the c-ares 1.33.0 release due out probably next week.

@jimwang118 jimwang118 deleted the fix-c-ares branch August 2, 2024 01:40
bradh352 added a commit to c-ares/c-ares that referenced this pull request Aug 2, 2024
Because AppVeyor's version of MSVC needed to be patched to build UWP
applications:
https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.

It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213

This PR fixes the build regression and also adds a GitHub action CI
workflow for building the UWP app so we can catch this in the future.

Fix By: Brad House (@bradh352)
liujinye-sys pushed a commit to open-vela/external_c-ares that referenced this pull request Jul 23, 2025
Because AppVeyor's version of MSVC needed to be patched to build UWP
applications:
https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.

It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213

This PR fixes the build regression and also adds a GitHub action CI
workflow for building the UWP app so we can catch this in the future.

Fix By: Brad House (@bradh352)
liujinye-sys pushed a commit to open-vela/external_c-ares that referenced this pull request Dec 16, 2025
Because AppVeyor's version of MSVC needed to be patched to build UWP
applications:
https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.

It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213

This PR fixes the build regression and also adds a GitHub action CI
workflow for building the UWP app so we can catch this in the future.

Fix By: Brad House (@bradh352)
michael-dev pushed a commit to HamelinPorts/android_external_c-ares that referenced this pull request Apr 25, 2026
Because AppVeyor's version of MSVC needed to be patched to build UWP
applications:
https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.

It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213

This PR fixes the build regression and also adds a GitHub action CI
workflow for building the UWP app so we can catch this in the future.

Fix By: Brad House (@bradh352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants