Skip to content

[toolchain] Fix try compile handling for Xbox#39654

Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom
walbourn:xboxtrycompile
Jul 11, 2024
Merged

[toolchain] Fix try compile handling for Xbox#39654
JavierMatosD merged 1 commit intomicrosoft:masterfrom
walbourn:xboxtrycompile

Conversation

@walbourn
Copy link
Member

@walbourn walbourn commented Jul 2, 2024

This updates the x64-xbox- triplets toolchain file to match the changes for try_compile support added in PR 24493.

@walbourn
Copy link
Member Author

walbourn commented Jul 2, 2024

The try-compile tests were failing for these triplets and now passes.

.\vcpkg.exe install try-compile:x64-xbox-scarlett --overlay-ports scripts\test_ports --enforce-port-checks
.\vcpkg.exe install try-compile:x64-xbox-scarlett-static --overlay-ports scripts\test_ports --enforce-port-checks
.\vcpkg.exe install try-compile:x64-xbox-xboxone --overlay-ports scripts\test_ports --enforce-port-checks
.\vcpkg.exe install try-compile:x64-xbox-xboxone-static --overlay-ports scripts\test_ports --enforce-port-checks

@walbourn
Copy link
Member Author

walbourn commented Jul 2, 2024

Verified GDK-aware ports using the new toolchain file: directxtex, directxtk12, directxmesh, uvatlas.

Working on a full test pass on all other ports now...

@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 3, 2024
@walbourn
Copy link
Member Author

walbourn commented Jul 3, 2024

Doing a 'world rebuild' and 1044 ports passed using the xbox triplets using the updated toolchain. Doing another pass to verify that number is the same with the older toolchain.

Note that many of the failures are due to issues with some dependencies like boost-atomic which do not properly support the WINFAMILY_API_GAMES partition, and/or dependencies on the 148 ports that are marked as not being able to support xbox.

@walbourn
Copy link
Member Author

walbourn commented Jul 6, 2024

1046 ports built with the older toolchain file for Xbox. The minc and clockutils now fail because of 'proper' try compile support which is by design.

@walbourn walbourn marked this pull request as ready for review July 7, 2024 01:22
@FrankXie05 FrankXie05 added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jul 8, 2024
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 8, 2024
@walbourn
Copy link
Member Author

@BillyONeal is there something else needing to happen to get this checked in?

@Neumann-A
Copy link
Contributor

@walbourn: Patience? Team meetings for PRs marked vcpkg-team-review only happen Thursdays as far as I am aware of it. (so maybe in the next 12h?)

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems substantially identical to #24493

@JavierMatosD JavierMatosD merged commit 4de4372 into microsoft:master Jul 11, 2024
@walbourn walbourn deleted the xboxtrycompile branch July 11, 2024 21:32
cenit pushed a commit to cenit/vcpkg that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants