-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[ffmpeg] Update to 7.0. #38011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[ffmpeg] Update to 7.0. #38011
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
eb63780
[ffmpeg] Update to 7.0.
Sibras 2f09d05
Update versions.
Sibras 994ee1e
[ffmpeg] Fix x86 nasm compile.
Sibras b806e24
[ffmpeg] Fix OSX cross compilation.
Sibras ecd27c2
[ffmpeg] Bump version.
Sibras 71dfa2f
fixup
Sibras f36fda9
Update ffmpeg.json
Sibras 87a1340
Merge branch 'master' into ffmpeg7
Sibras bbc4155
Update ffmpeg.json
Sibras d5a8237
[ffmpeg] fix chromium patch
Sibras 8cde7cb
Update ffmpeg.json
Sibras 8a79791
[aubio] Update to latest.
Sibras b9da0f3
[aubio] update version.
Sibras 2001289
Merge branch 'master' into ffmpeg7
Sibras 1a7fad7
Update ffmpeg.json
Sibras 0febba8
[ffmpeg] Add d3d12va support.
Sibras 1574421
[ffpmpeg]: Fix patch.
Sibras 593e0c4
Update ffmpeg.json
Sibras 672dc03
[ffmpeg] Attempt to fix osx link errors.
Sibras e93240a
Update ffmpeg.json
Sibras 1b69015
Revert "[ffmpeg] Attempt to fix osx link errors."
Sibras 7a64773
[ffmpeg] disable opencl on osx.
Sibras 7a37c8d
Update ffmpeg.json
Sibras 6d49154
[aubio] disable on osx.
Sibras d995406
Update aubio.json
Sibras 6ac1283
Merge remote-tracking branch 'upstream' into ffmpeg7
Sibras cbc1c8b
Update ffmpeg.json
Sibras 1145360
simplify osx patch.
Sibras 30d85e4
Update ffmpeg.json
Sibras 466fc07
Revert "[aubio] disable on osx."
Sibras f89edc7
Update aubio.json
Sibras 6d89823
fix patch
Sibras c6c57cb
Update ffmpeg.json
Sibras 2103055
Merge branch 'master' of https://github.com/microsoft/vcpkg into ffmpeg7
4e5b531
remove port-version
c2f3437
update git-tree
0ea67f8
format
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/src/io/source_avcodec.c b/src/io/source_avcodec.c | ||
| index 71ea8b5f..ad91f5eb 100644 | ||
| --- a/src/io/source_avcodec.c | ||
| +++ b/src/io/source_avcodec.c | ||
| @@ -345,8 +345,8 @@ void aubio_source_avcodec_reset_resampler(aubio_source_avcodec_t * s) | ||
| av_channel_layout_default(&input_layout, s->input_channels); | ||
| av_channel_layout_default(&output_layout, s->input_channels); | ||
|
|
||
| - av_opt_set_chlayout(avr, "in_channel_layout", &input_layout, 0); | ||
| - av_opt_set_chlayout(avr, "out_channel_layout", &output_layout, 0); | ||
| + av_opt_set_chlayout(avr, "in_chlayout", &input_layout, 0); | ||
| + av_opt_set_chlayout(avr, "out_chlayout", &output_layout, 0); | ||
| #else | ||
| int64_t input_layout = av_get_default_channel_layout(s->input_channels); | ||
| int64_t output_layout = av_get_default_channel_layout(s->input_channels); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/configure b/configure | ||
| index 4f5353f84b..dd9147c677 100755 | ||
| --- a/configure | ||
| +++ b/configure | ||
| @@ -5607,8 +5607,8 @@ check_cppflags -D_FILE_OFFSET_BITS=64 | ||
| check_cppflags -D_LARGEFILE_SOURCE | ||
|
|
||
| add_host_cppflags -D_ISOC11_SOURCE | ||
| check_host_cflags_cc -std=$stdc ctype.h "__STDC_VERSION__ >= 201112L" || | ||
| - check_host_cflags_cc -std=c11 ctype.h "__STDC_VERSION__ >= 201112L" || die "Host compiler lacks C11 support" | ||
| + check_host_cflags_cc -std=c11 ctype.h "__STDC_VERSION__ >= 201112L" | ||
|
|
||
| check_host_cflags -Wall | ||
| check_host_cflags $host_cflags_speed | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no host_cc in vcpkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host_cc is a command line arg passed to ffmpeg configure script. Due to the way the portfile is calling ffmpegs configure (calld it as cross compile) it fails without this command option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will also fail with this option except for "almost-native" cross builds.
vcpkg allows you to tell the compiler and flags for the target triplet (e.g. android, ios).
vcpkg allows you to know the host triplet and its install prefix.
vcpkg doesn't allow you to tell the compiler and flags for the host triplet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR
vcpkg_configure_maketurns the host cc (CC_FOR_BUILD) into a no-op forVCPKG_CROSSCOMPILING.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately someone set the cross compile flag for ffmpeg as always on in PR #23001 (see portfile line 459). I have no idea why or what they were trying to fix but I have no way of testing all the various triplets that this effects in order to work out how to disable it again.
Due to changes in ffmpegs internal configure script in 7.0 it now does additional checks on the host compiler when the cross compile flag is passed to it. This is why the line had to be uncommented as its required to pass those checks. The actual compilation though functions the same as previously.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the ffmpeg port doesnt use
vcpkg_configure_makeIt uses
vcpkg_execute_required_processto run a custom bash script. The--host_cccommand line option is for this bash script to pass through to ffmpegs internal configure script