Skip to content

[pmdk] Fix linux compilation #33766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicroms merged 3 commits into from
Sep 18, 2023
Merged

[pmdk] Fix linux compilation #33766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
376d4a0
[pmdk] Add !linux supports
Sep 14, 2023
6c93906
update version
Sep 14, 2023
ff4f6b6
update version
Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ports/pmdk/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "pmdk",
"version": "1.12.0",
"port-version": 1,
"port-version": 2,
"description": "Persistent Memory Development Kit",
"homepage": "https://github.com/pmem/pmdk",
"license": "BSD-3-Clause",
"supports": "!(arm | x86)",
"supports": "!(linux | arm | x86)",
Copy link
Contributor

@dg0yt dg0yt Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this "fix linux compilation"?

It is just another incomplete port. And note that "Support for Windows and FreeBSD has been deprecated since the PMDK 1.13.0 release and was removed in the PMDK 2.0 release.", https://pmem.io/pmdk/

Copy link
Contributor Author

@JonLiu1993 JonLiu1993 Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it does not fix pmdk compilation under linux, because the current pmdk compilation method in vcpkg is compiled through sln files. I added supports just to tell users that linux is not supported for the time being. The supports here are really not suitable for the latest version of pmdk 2.0.0. I will upgrade to the latest version 2.0.0 later.

Copy link
Contributor

@dg0yt dg0yt Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now we have a baseline regression:

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.

Copy link
Contributor

@dg0yt dg0yt Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not to mention that msbuild doesn't support osx or android or ...)

Copy link
Contributor Author

@JonLiu1993 JonLiu1993 Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you see this REGRESSION?

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.

Copy link
Contributor

@dg0yt dg0yt Sep 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again today: https://dev.azure.com/vcpkg/public/_build/results?buildId=94432&view=results

"dependencies": [
"getopt",
{
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6458,7 +6458,7 @@
},
"pmdk": {
"baseline": "1.12.0",
"port-version": 1
"port-version": 2
},
"pngpp": {
"baseline": "0.2.10",
Expand Down
5 changes: 5 additions & 0 deletions versions/p-/pmdk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "b208389a2bc32898f0f4d13c5f222015ce9bd072",
"version": "1.12.0",
"port-version": 2
},
{
"git-tree": "5dc7f0e5a4d6348ac49617010105730775580f78",
"version": "1.12.0",
Expand Down