[vcpkg] Enhance detection of Anti-Virus messing with builds#33279
Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom Aug 29, 2023
Merged
[vcpkg] Enhance detection of Anti-Virus messing with builds#33279dan-shaw merged 3 commits intomicrosoft:masterfrom
dan-shaw merged 3 commits intomicrosoft:masterfrom
Conversation
The current error message matching attempt is too strict as the error message occasionally spells out the extension (i.e. `mt.exe` instead of `mt`).
MonicaLiu0311
added
the
category:tool-update
dan-shaw
approved these changes
Aug 22, 2023
added 2 commits
August 22, 2023 23:12
…fix-build-av-workaround
…fix-build-av-workaround
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MonicaLiu0311
approved these changes
Aug 29, 2023
MonicaLiu0311
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently encountered AV related build failures and wondered why the retry logic in
vcpkg_execute_build_process.cmakedidn't kick in. The error message generated on the failing machines includes themt-executable's file-extension. The detection logic previously accounted for this until the function was overhauled in #18838 / #18488 / 6c9da67. However, I believe this to be an oversight.