Skip to content

[scripts-audit] vcpkg_execute_*#18488

Closed
strega-nil wants to merge 10 commits intomicrosoft:masterfrom
strega-nil:vcpkg_execute_
Closed

[scripts-audit] vcpkg_execute_*#18488
strega-nil wants to merge 10 commits intomicrosoft:masterfrom
strega-nil:vcpkg_execute_

Conversation

@strega-nil
Copy link
Contributor

This goes through the vcpkg_execute functions and audits them from issue #17691.

It additionally adds the following:

  • z_vcpkg_forward_output_variable macro - this allows one to forward to parent scope what makes sense
  • Z_VCPKG_EXECUTE_PROCESS_NAME - either _execute_process or execute_process, whichever is allowed to execute in download mode, for use via cmake_language(CALL)

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms
Copy link
Contributor

Closed for rollup PR #18838

@dg0yt
Copy link
Contributor

dg0yt commented Jul 6, 2021

Closed but still eating CI for rebuilding the world ...

@BillyONeal
Copy link
Member

Closed but still eating CI for rebuilding the world ...

Thanks for the note, I cancelled that run

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Jul 13, 2021
BillyONeal pushed a commit that referenced this pull request Jul 14, 2021
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil)

[scripts-audit] vcpkg_from_*

* [rollup:2021-07-06 2/8] PR #18319 (@strega-nil)

[scripts-audit] add guidelines for cmake

* [rollup 2021-07-06 3/8] PR #18410 (@mheyman)

[vcpkg-cmake-config] documentation fix

* [rollup:2021-07-06 4/8] PR #18488 (@strega-nil)

[scripts-audit] vcpkg_execute_*

* [rollup:2021-07-06 5/8] PR #18517 (@strega-nil)

[scripts-audit] vcpkg_extract_source_archive

* [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013)

[vcpkg doc] Update examples

* [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY)

[vcpkg] Update the minimum version of vcpkg

* [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft)

[vcpkg_from_git] Fix error if downloads folder does not exist

* build docs!

* fix bond:*-windows

* fix nmap

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: Michael Heyman <Michael.Heyman@jhuapl.edu>
Co-authored-by: NancyLi1013 <lirui09@beyondsoft.com>
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Co-authored-by: Robert Schumacher <ras0219@outlook.com>
@strega-nil strega-nil deleted the vcpkg_execute_ branch July 16, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants