[vcpkg-find-acquire-program] Revise test port#31557
Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom May 24, 2023
Merged
[vcpkg-find-acquire-program] Revise test port#31557dan-shaw merged 5 commits intomicrosoft:masterfrom
dan-shaw merged 5 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Note: I will be converting your PR to draft status. Please convert PR to ready for review after fixing CI errors: |
Contributor
Author
|
It is not just https://github.com/microsoft/vcpkg/labels/category%3Acode-cleanup: It actually ensures proper ABI hashing, and thus proper triggering of the CI port. Without spelling out |
Contributor
Author
|
After some confusion, programs with interpreters are now handled properly (again). |
Adela0814
previously approved these changes
May 23, 2023
dan-shaw
reviewed
May 23, 2023
Contributor
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| list(APPEND missing "${program}: ${${program}}") | |
| list(APPEND missing "${variable}: ${program}") |
Contributor
Author
There was a problem hiding this comment.
Good catch. The last commit reverted too much.
I pushed a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #30780.