Skip to content

[vcpkg-find-acquire-program] Revise test port#31557

Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom
dg0yt:vcpkg-ci
May 24, 2023
Merged

[vcpkg-find-acquire-program] Revise test port#31557
dan-shaw merged 5 commits intomicrosoft:masterfrom
dg0yt:vcpkg-ci

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 22, 2023

Complements #30780.

  • Changes comply with the maintainer guide
  • The "supports" clause reflects platforms that may be fixed by this new version

@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. Please convert PR to ready for review after fixing CI errors:

CMake Error at scripts/test_ports/vcpkg-find-acquire-program/portfile.cmake:48 (message):
  The following programs do not exist:

     BAZEL
     BISON
     FLEX
     GIT
     GN
     MESON
     NINJA
     PERL
     PKGCONFIG
     PYTHON2
     PYTHON3
     SCONS
     SWIG
     YASM
     7Z
     ARIA2
     CLANG
     DARK
     DOXYGEN
     GASPREPROCESSOR
     GO
     GPERF
     JOM
     NASM
     NUGET
     RUBY
Call Stack (most recent call first):
  scripts/ports.cmake:147 (include)

@Adela0814 Adela0814 marked this pull request as draft May 22, 2023 09:41
@dg0yt dg0yt marked this pull request as ready for review May 22, 2023 18:24
@dg0yt
Copy link
Contributor Author

dg0yt commented May 22, 2023

It is not just https://github.com/microsoft/vcpkg/labels/category%3Acode-cleanup: It actually ensures proper ABI hashing, and thus proper triggering of the CI port. Without spelling out vcpkg_find_acquire_program(ACTUAL_NAME) in the portfile, PR CI may fail to detect problems in PRs changig vcpkg_find_acquire_program(ACTUAL_NAME).cmake.

@dg0yt
Copy link
Contributor Author

dg0yt commented May 22, 2023

After some confusion, programs with interpreters are now handled properly (again).

  The following programs do not exist:

     EXPECTED_FAIL: /PROGRAM
     EXPECTED_FAIL (interpreter): /INTERPRETER

Adela0814
Adela0814 previously approved these changes May 23, 2023
@Adela0814 Adela0814 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. category:port-bug The issue is with a library, which is something the port should already support labels May 23, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

Suggested change
list(APPEND missing "${program}: ${${program}}")
list(APPEND missing "${variable}: ${program}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The last commit reverted too much.
I pushed a fix.

@dan-shaw dan-shaw merged commit 3bd49b7 into microsoft:master May 24, 2023
@dg0yt dg0yt deleted the vcpkg-ci branch May 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants