[vcpkg_find_acquire_program] Split out program data#30780
[vcpkg_find_acquire_program] Split out program data#30780BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
|
I like this direction. Will include it in presentation to other maintainers on where vcpkg_find_acquire_program goes. You've already done awesome stuff, so don't really want to ask you to do more things, but if you're interested you could change the ones that |
|
This PR doesn't change what is done at runtime, it just distibutes it differently over the script files. |
|
(In particular, I do not want to trigger more world rebuilds than needed. Tired of fixing baseline regressions.) |
|
I will force merge this around baseline issues if I get support for the proposal in this direction, so don't lose sleep over that |
|
Thanks! |
For #30483 (comment):
Allow changing data for a single tool without rebuilding all users of
vcpkg_find_acquire_program.Effects on ABI hashing:
vcpkg_find_acquire_program.cmakeis input to the ABI hash for direct uses of the function, but not for indirect uses (e.g. viavcpkg_fixup_pkgconfig).PYTHON3,PERL) are no longer input to the ABI hash if used transitively (GASPREPROCESSOR,MESON).I think the limitations shouldn't be overrated: Most indirect uses weren't covered already before this change (cf. first point). ATM all uses in the repo match literally.
Example for libpcap:
CC @BillyONeal