Skip to content

Replaced "disable-gpl" feature with "gpl" #30978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillyONeal merged 1 commit into from
Apr 27, 2023
Merged

Replaced "disable-gpl" feature with "gpl" #30978

BillyONeal merged 1 commit into from
Apr 27, 2023

Conversation

@David-Ely
Copy link
Contributor

@David-Ely David-Ely commented Apr 20, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 20, 2023

Fixes #30631 (comment).

@jimwang118 jimwang118 self-assigned this Apr 20, 2023
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 20, 2023
@David-Ely David-Ely marked this pull request as ready for review April 21, 2023 05:01
@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 21, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Apr 21, 2023

disable-gpl makes sense in that "can deploy to not GPL places" is a feature. But gpl makes sense in that turning on the feature turns on more APIs. I'm not sure how to proceed, tagged to talk with other maintainers about it.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 22, 2023

Either no-gpl must go in this port, or gpl should go in other ports.
It is too important to allow for inconsistencies.

BillyONeal
BillyONeal approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicroms @JavierMatosD @dan-shaw @ras0219-msft and I discussed this today.

It seems unlikely that any of these GPL features are well founded, given that there is no way to force all such features to be off. However, given that we have these features here, the consistent pattern elsewhere in vcpkg today is that "gpl means turning on the gpl things and disable-gpl does not exist", and this PR is in keeping with that.

Therefore, we are merging this.

@BillyONeal BillyONeal merged commit 5971b70 into microsoft:master Apr 27, 2023
@jimwang118 jimwang118 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@jimwang118 jimwang118

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@David-Ely @dg0yt @BillyONeal @jimwang118