X264 features #30631
Merged
X264 features #30631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree company="ImmersaView Pty Ltd" |
Adela0814
added
the
category:port-feature
dg0yt
reviewed
Apr 6, 2023
Comment on lines
+84
to
+86
| if("disable-gpl" IN_LIST FEATURES) | ||
| vcpkg_list(APPEND OPTIONS --disable-gpl) | ||
| endif() |
Contributor
There was a problem hiding this comment.
Is this feature additive as requested in the guidelines?
It seems to operate in the opposite way than gpl features in ffmpeg and gstreamer.
Contributor
Author
There was a problem hiding this comment.
I think technically it does. But it is the opposite of how ffmpeg and gstreamer do it. If you would like I'm happy create a new PR that changes it to match their method?
Contributor
There was a problem hiding this comment.
--disable-gpl disable GPL-only features
It is not additive. It must be changed to match vcpkg guidelines.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] SHA512s are updated for each updated download[ ] The "supports" clause reflects platforms that may be fixed by this new version[ ] Any fixed CI baseline entries are removed from that file.[ ] Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.