Skip to content

Conversation

@chausner
Copy link
Contributor

@chausner chausner commented Apr 2, 2023

This adds libcoro 0.9 as a new port.

This library does not support Windows. Also, CI builds x64-osx are disabled because the GCC compiler version is too old.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 3, 2023
@chausner
Copy link
Contributor Author

chausner commented Apr 3, 2023

I am wondering if we should include !osx in supports given that Clang is not supported by the library and it is the default compiler on macOS? The library itself might be compatible to macOS, though, if a recent version of gcc is used.

@chausner chausner marked this pull request as draft April 4, 2023 06:21
@chausner chausner marked this pull request as ready for review April 4, 2023 17:45
@vicroms
Copy link
Member

vicroms commented Apr 5, 2023

As it is, the library is not being tested in any way in CI.
We should wait to merge until a VM update allows us to test this (at least on Linux).

Upstream requirements

    g++10.2.1
    g++10.3.1

Track: microsoft/azure-pipelines-agent#3834

@vicroms vicroms added depends:vm-update PR contains changes to the VM provisioning scripts requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Apr 5, 2023
@FrankXie05
Copy link
Contributor

Waiting for the vm to update, temporarily turning to draft status. Once the update is complete, it will be retested.

@FrankXie05 FrankXie05 marked this pull request as draft May 9, 2023 03:08
@dg0yt
Copy link
Contributor

dg0yt commented Aug 6, 2023

@chausner Could you please sync the branch master? :)

Done! But it seems some of the CI builds are stuck..

Just add an empty commit to restart them.

@chausner
Copy link
Contributor Author

chausner commented Aug 6, 2023

@chausner Could you please sync the branch master? :)

Done! But it seems some of the CI builds are stuck..

Just add an empty commit to restart them.

Done. The x64_linux pipeline failed due to some unrelated build error of llvm.

@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05
Copy link
Contributor

/usr/include/c++/11/atomic: In member function ‘bool std::atomic<_Tp>::compare_exchange_weak(_Tp&, _Tp, std::memory_order, std::memory_order)’:
/usr/include/c++/11/atomic:323:9: error: there are no arguments to ‘__is_valid_cmpexch_failure_order’ that depend on a template parameter, so a declaration of ‘__is_valid_cmpexch_failure_order’ must be available [-fpermissive]
  323 |         __glibcxx_assert(__is_valid_cmpexch_failure_order(__f));
      |         ^~~~~~~~~~~~~~~~

install-x64-linux-dbg-out.log

It seems that it is still due to the problem of gcc version. cc @BillyONeal @vicroms

@chausner
Copy link
Contributor Author

@FrankXie05 Could you please have another look? I updated the library to 0.9 and it appears to succeed in CI now. The two errors in CI seem unrelated:

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.
REGRESSION: kf5kio:x64-linux failed with BUILD_FAILED. If expected, add kf5kio:x64-linux=fail to /mnt/vss/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

@dg0yt
Copy link
Contributor

dg0yt commented Sep 24, 2023

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.

#33766 (comment)

@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 requested review from vicroms and removed request for dg0yt September 27, 2023 02:27
@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 27, 2023
@vicroms
Copy link
Member

vicroms commented Sep 29, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms vicroms merged commit 38dd6b1 into microsoft:master Oct 2, 2023
@chausner chausner deleted the libcoro-0.7 branch October 2, 2023 18:29
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
* Add libcoro 0.7

* Update CI baseline

* Add "supports": "!windows"

* Update CI baseline

* Remove unneeded vcpkg-cmake-config dependency

* Update CI baseline

* Disable x64-linux and x64-osx in ci.baseline.txt

* Apply code review suggestions

* Update CI baseline

* Add patch to disable git config

* Update CI baseline

* Fix patch

* Update CI baseline

* Allow shared library builds

* Update CI baseline

* Update libcoro to version 0.8

* Update CI baseline

* Update CI baseline

* Fix line endings

* Update CI baseline

* Fix hash

* Update CI baseline

* Update version database

* Force rerun of CI pipeline

* Update to libcoro 0.9

* Update CI baseline

* Replace manual dependency check with manifest-based one

* Remove v0.8 version

* Update CI baseline

---------

Co-authored-by: chausner <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>
BillyONeal pushed a commit that referenced this pull request Jun 17, 2024
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=103938&view=results.
```
PASSING, REMOVE FROM FAIL LIST: c4core:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: botan:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: libcoro:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: stx:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: yoga:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: c4core:x64-android
PASSING, REMOVE FROM FAIL LIST: botan:x64-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:x64-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:x64-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-android
PASSING, REMOVE FROM FAIL LIST: libcoro:x64-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:x64-android
PASSING, REMOVE FROM FAIL LIST: stx:x64-android
PASSING, REMOVE FROM FAIL LIST: yoga:x64-android
PASSING, REMOVE FROM FAIL LIST: c4core:arm64-android
PASSING, REMOVE FROM FAIL LIST: botan:arm64-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm64-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm64-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm64-android
PASSING, REMOVE FROM FAIL LIST: libcoro:arm64-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm64-android
PASSING, REMOVE FROM FAIL LIST: stx:arm64-android
PASSING, REMOVE FROM FAIL LIST: yoga:arm64-android
```

Added `c4core` to `ci.baseline.txt` by #29406, which has been fixed by
#39287.
Added `botan` to `ci.baseline.txt` by #37252, which has been fixed by
#38975.
Added `concurrencpp` to `ci.baseline.txt` by #29406, which may have been
fixed by #39160.
Added `cppgraphqlgen` to `ci.baseline.txt` by #29406, which may have
been fixed by #38975.
Added `graphicsmagick` to `ci.baseline.txt` by #29406, which has been
fixed by #39210.
Added `libcoro` to `ci.baseline.txt` by #30623, which may have been
fixed by #38975.
Added `ms-ifc-sdk` to `ci.baseline.txt` by #35972, which may have been
fixed by #39210.
Added `stx` to `ci.baseline.txt` by #29406, which may have been fixed by
#38975.
Added `yoga` to `ci.baseline.txt` by #37507, which may have been fixed
by #38975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants