[icu] Fix #30532: trying to set rpath on missing libicutu #30544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
the
category:port-bug
microsoft#29196 introduced new feature flag `[tools]` which prevents generation of `libicutu`. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries. This PR dynamically detects presence of `[tools]` feature and adds `libicutu` for rpath fix as necessary.
janisozaur
force-pushed
the
icu-dynamic-no-libicutu
branch
from
b009cff to
ac80fda
Compare
Contributor
|
Depends on #30546 |
MonicaLiu0311
added
the
depends:different-pr
Contributor
Author
|
I plan to do a release that would benefit from this PR, can I expect this to be merged today? I can see #30456 which you mentioned is already approved and has all the checks green |
MonicaLiu0311
removed
the
depends:different-pr
added 2 commits
April 10, 2023 15:48
MonicaLiu0311
approved these changes
Apr 12, 2023
MonicaLiu0311
added
the
info:needs-maintainer-attention
Contributor
|
Feature |
Member
|
Thanks! |
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29196 introduced new feature flag
[tools]which prevents generation oflibicutu. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries.This PR dynamically detects presence of
[tools]feature and addslibicutufor rpath fix as necessary.Fixes #30532
./vcpkg x-add-version --alland committing the result.