[icu] Add tools, fix building for ios #29196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BillyONeal
approved these changes
Jan 27, 2023
BillyONeal
added
the
info:needs-maintainer-attention
Member
|
Thanks for the feature add! |
BillyONeal
added
the
category:port-feature
7 tasks
janisozaur
added a commit
to janisozaur/vcpkg
that referenced
this pull request
Mar 30, 2023
microsoft#29196 introduced new feature flag `[tools]` which prevents generation of `libicutu`. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries. This PR dynamically detects presence of `[tools]` feature and adds `libicutu` for rpath fix as necessary.
BillyONeal
pushed a commit
that referenced
this pull request
Apr 12, 2023
#29196 introduced new feature flag `[tools]` which prevents generation of `libicutu`. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries. This PR dynamically detects presence of `[tools]` feature and adds `libicutu` for rpath fix as necessary. Co-authored-by: Monica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26727
./vcpkg x-add-version --alland committing the result.