Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gumbo, litehtml] fix dupplicate gumbo symbols #29804

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

rioki
Copy link
Contributor

@rioki rioki commented Feb 23, 2023

  1. Fixes duplicate gumbo symbols introduced by PR#[litehtml] new port version 0.6 #29673
  2. Fixes gumbo CMake include folder exports

And because I am an external contributor:

  • Changes where crosschecked with other gumbo users (libmupdf)
  • Changes comply with the maintainer guide
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

@rioki rioki changed the title Litehtml gumbo fix [gumbo, litehtml] fix dupplicate gumbo symbols Feb 23, 2023
@rioki
Copy link
Contributor Author

rioki commented Feb 23, 2023

I don't understand how qttools is now failing, but I am looking into it.

@rioki rioki marked this pull request as draft February 23, 2023 09:15
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Feb 23, 2023
@JonLiu1993
Copy link
Member

@rioki, Please get failure logs here. Please ping me if you need any help.

@rioki
Copy link
Contributor Author

rioki commented Feb 23, 2023

@JonLiu1993 Thank you. I already found the failure logs; unfortunately this is not the first time I threw the vcpkg CI. My confusion came from the fact that it worked fine on my machine. But after a git clean and rebuild I now have the same issue locally. I am still confused how it broke, but I will soon find out.

@rioki rioki marked this pull request as ready for review February 23, 2023 17:16
@BillyONeal BillyONeal merged commit d744711 into microsoft:master Feb 23, 2023
@BillyONeal
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants