-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[litehtml] new port version 0.6 #29673
Conversation
Note: litehtml is vendored by qttools currently. I don't know if it is visible from the outside or just a part of qtassistent. |
As far as I can see the QT version runs as qlitehtml and has some changes to the code. It's API and ABI incompatible as it uses QT specific types and should be considered a sperate fork. If I see it correctly qtassistent consumes qlitehtml as a static library and never installs anything. |
qlitehtml is a wrapper and needs litehtml. It will use an installed version if it is found: So AFAICT qttools must use the vcpkg version of litehtml if we don't want to have two providers of the same symbols. |
I don't think that is currently needed. |
All test passed with following triplets: |
IIUC litehtml still needs to be devendored from qttools. |
I will see if I can devendor litehtml this weekend form qttools. |
2192ad3
I fixed the CMakeLists.txt in qlitehtml/src so that is used the vcpkg litehtml. git still pulls the submodule, but I have no idea how to fix that, since I can patch the .gitmodules but that happens only after the submodule was pulled. |
Looking into why it fails on the CI (works on my machine™) |
I fixed litehtml exposing the vendored gumbo for CMake to handle it's dependencies cleanly. The project is defunct, thus I don't think making a unique port is needed. |
There is a gumbo port, and we have a file conflict in CI now. |
Sorry for missing that. I will look into fixing this. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.