-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7zip] Add complete public header files #27569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider using file(GLOB ...)
?
Most of these headers are internal and symbols inside them are not exported from shared library. |
For my WIP cross-platform 7zip library wrapper it was enough to add just these files:
Not sure about files in |
@Osyotr Maybe I should just go and ask upstream about this. |
I do wonder if this requires more examination than I originally anticipated. I think that perhaps the C code is entirely separate to the C++ code in this library and as far as I can see, the C code only provides LZMA decompression while the C++ code supports all archive formats. I may be incorrect about this but if I'm understanding correctly, it may actually be worth splitting this package into two variants or perhaps just providing the C++ header files. I've honestly struggled to really understand the way this is structured; compared to both libarchive and unrar, the 7-Zip SDK is significantly more complicated to consume. Huge thanks for all your help! |
Thanks! |
* [7zip] Add complete public header files * version * simplify * version * add end line * vdb
Fix #27553
Note: Add complete public header files
Usage test succeeded