Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7zip] Add complete public header files #27569

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

FrankXie05
Copy link
Contributor

Fix #27553

Note: Add complete public header files

Usage test succeeded

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 31, 2022
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider using file(GLOB ...)?

@Osyotr
Copy link
Contributor

Osyotr commented Oct 31, 2022

Most of these headers are internal and symbols inside them are not exported from shared library.

@FrankXie05
Copy link
Contributor Author

@dg0yt @dg0yt file(GLOB) method is better, as Osyotr said, I'm looking for if these files should all be installed. 🧐

@Osyotr
Copy link
Contributor

Osyotr commented Oct 31, 2022

For my WIP cross-platform 7zip library wrapper it was enough to add just these files:

CPP/Common/MyCom.h
CPP/Common/MyGuidDef.h

Not sure about files in C/ folder.

@FrankXie05
Copy link
Contributor Author

@Osyotr Maybe I should just go and ask upstream about this.

@fgimian
Copy link

fgimian commented Nov 1, 2022

I do wonder if this requires more examination than I originally anticipated. I think that perhaps the C code is entirely separate to the C++ code in this library and as far as I can see, the C code only provides LZMA decompression while the C++ code supports all archive formats.

I may be incorrect about this but if I'm understanding correctly, it may actually be worth splitting this package into two variants or perhaps just providing the C++ header files.

I've honestly struggled to really understand the way this is structured; compared to both libarchive and unrar, the 7-Zip SDK is significantly more complicated to consume.

Huge thanks for all your help!
Fotis

github-actions[bot]
github-actions bot previously approved these changes Nov 22, 2022
github-actions[bot]
github-actions bot previously approved these changes Nov 22, 2022
@FrankXie05 FrankXie05 marked this pull request as ready for review November 22, 2022 07:50
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 22, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

@JavierMatosD JavierMatosD merged commit 6b49f83 into microsoft:master Nov 22, 2022
@FrankXie05 FrankXie05 deleted the dev/Frank/27553 branch November 23, 2022 01:49
lukaszmoroz pushed a commit to lukaszmoroz/vcpkg that referenced this pull request Nov 24, 2022
* [7zip] Add complete public header files

* version

* simplify

* version

* add end line

* vdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7zip Please include 7z.h in the distribution for C developers
6 participants