Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7zip Please include 7z.h in the distribution for C developers #27553

Closed
fgimian opened this issue Oct 30, 2022 · 4 comments · Fixed by #27569
Closed

7zip Please include 7z.h in the distribution for C developers #27553

fgimian opened this issue Oct 30, 2022 · 4 comments · Fixed by #27569
Assignees
@FrankXie05
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@fgimian
Copy link

fgimian commented Oct 30, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
The main C header file 7z.h for 7-Zip is missing which makes it impossible to use the vcpkg package on C projects.

This header file includes the primary functions used to interact with the library in C, such as:

  • SzArEx_Init
  • SzArEx_Free
  • SzArEx_Open
  • SzArEx_Extract

Proposed solution
Please include include\7zip\C\7z.h in the distribution 😄

Describe alternatives you've considered
I don't really have a workaround for this sadly.

Additional context
N/A
@FrankXie05
Copy link
Contributor

@fgimian 7zip headers are provided by upstream,

vcpkg/ports/7zip/CMakeLists.txt

Line 401 in 5220969

set(PUBLIC_HEADERS

vcpkg/ports/7zip/portfile.cmake

Line 14 in 2537044

file(COPY "${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt" DESTINATION "${SOURCE_PATH}")

you can ask upstream if this header is publicly installable. :)
https://sourceforge.net/p/sevenzip/discussion/

@FrankXie05 FrankXie05 added the category:question This issue is a question label Oct 31, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Oct 31, 2022

@FrankXie05 You are pointing to vcpkg's vendored build system for 7zip, so the bug and maintenance burden is clearly in vcpkg, not upstream.

@FrankXie05
Copy link
Contributor

@dg0yt Sorry, I got it wrong. i will fix this.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support and removed category:question This issue is a question labels Oct 31, 2022
@fgimian
Copy link
Author

fgimian commented Oct 31, 2022

@dg0yt Sorry, I got it wrong. i will fix this.

Thank you so much for your help 😄

@FrankXie05 FrankXie05 mentioned this issue Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[7zip] Add complete public header files FrankXie05/vcpkg
3 participants
@fgimian @dg0yt @FrankXie05