-
Notifications
You must be signed in to change notification settings - Fork 7k
[liblrc] create a new port #27023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[liblrc] create a new port #27023
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
65bda6f
[lrc-tool] create a new port
rinechran 079b1cb
[lrc-tool] fix portfile.cmake
rinechran 14ccf46
[lrc-tool] fix format-manifest portfile.cmake
rinechran 5f75783
[lrc-tool] fix git-tree version
rinechran 5edbeca
[liblrc] remove include copy
rinechran 76f6d40
Update version database
rinechran e5d684a
[liblrc] not support osx
rinechran 65c87b7
Update version database
rinechran b9025b3
[liblrc] Apply suggestions from code review
rinechran bc8ffdb
[liblrc] fix code review
rinechran dceda8c
Update version database
rinechran d033049
[liblrc] make CMakeLists.txt to patch
luncliff f8e4375
[liblrc] add unofficial
rinechran c6582c2
[liblrc] add unofficial namespace
rinechran f010290
[liblrc] Update version database
rinechran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 6b2175e..2aa699b 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -1,8 +1,7 @@ | ||
cmake_minimum_required(VERSION 3.2.0) | ||
project(LRCTools VERSION 1.0.0) | ||
|
||
-set(CMAKE_CXX_FLAGS | ||
- "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra -Wno-missing-braces") | ||
+set(CMAKE_CXX_STANDARD 11) | ||
|
||
include_directories(${CMAKE_CURRENT_LIST_DIR}) | ||
|
||
@@ -12,7 +11,22 @@ include(CPack) | ||
|
||
enable_testing() | ||
|
||
-add_subdirectory(third_party) | ||
add_subdirectory(liblrc) | ||
-add_subdirectory(cli) | ||
-add_subdirectory(test) | ||
+# headers | ||
+install(FILES ${PROJECT_SOURCE_DIR}/liblrc/lrc_parser.h | ||
+ ${PROJECT_SOURCE_DIR}/liblrc/lyrics.h | ||
+ ${PROJECT_SOURCE_DIR}/liblrc/utils.h | ||
+ DESTINATION include/liblrc | ||
+) | ||
+# library with unofficial config | ||
+install(TARGETS lrc | ||
+ EXPORT unofficial-liblrcConfig | ||
+ RUNTIME DESTINATION bin | ||
+ LIBRARY DESTINATION lib | ||
+ ARCHIVE DESTINATION lib | ||
+) | ||
+# share/liblrc will be fixed in portfile.cmake | ||
+install(EXPORT unofficial-liblrcConfig | ||
+ NAMESPACE unofficial:: | ||
rinechran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
+ DESTINATION share/liblrc | ||
rinechran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
+) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
vcpkg_from_github( | ||
OUT_SOURCE_PATH SOURCE_PATH | ||
REPO ywh233/LRC-Tools | ||
REF 1fc3872320cd449933bffefc6527928262ee0629 | ||
SHA512 5b0a52a557ffb28554b33e77efb3832944facfd4e039d8afe60c322d56872eb12cb93f3974d17f083c659dcddf9c63075d3b09ba6abd3adba7b40b2ffb615f1c | ||
PATCHES | ||
set_up_compile_error.patch | ||
fix-cmake.patch | ||
) | ||
|
||
vcpkg_cmake_configure(SOURCE_PATH ${SOURCE_PATH}) | ||
vcpkg_cmake_install() | ||
vcpkg_cmake_config_fixup(CONFIG_PATH share/liblrc PACKAGE_NAME unofficial-liblrc) | ||
rinechran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
rinechran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share") | ||
|
||
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/liblrc/lyrics.cc b/liblrc/lyrics.cc | ||
index b1a8c87..4fa16fa 100644 | ||
--- a/liblrc/lyrics.cc | ||
+++ b/liblrc/lyrics.cc | ||
@@ -5,7 +5,7 @@ | ||
//****************************************** | ||
|
||
#include "lyrics.h" | ||
- | ||
+#include <limits> | ||
#include <assert.h> | ||
|
||
#include <algorithm> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"name": "liblrc", | ||
"version": "1.0.0", | ||
"description": "Tools for parsing and playing back LRC lyrics.", | ||
"homepage": "https://github.com/ywh233/LRC-Tools", | ||
"license": null, | ||
"supports": "!osx", | ||
"dependencies": [ | ||
{ | ||
"name": "vcpkg-cmake", | ||
"host": true | ||
}, | ||
{ | ||
"name": "vcpkg-cmake-config", | ||
"host": true | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"versions": [ | ||
{ | ||
"git-tree": "a93aba0a682f18848e4dd8edd6468368dc8c25c8", | ||
"version": "1.0.0", | ||
"port-version": 0 | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.