[liblrc] create a new port #27023

rinechran · 2022-09-28T14:40:57Z

What does your PR fix?

Tools for parsing and playing back LRC lyrics.

Which triplets are supported/not supported? Have you updated the CI baseline?

all
Does your PR follow the maintainer guide?

yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

Use the version scheme "version" instead of "version-string" in port "liblrc".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f82fa45df07a446bab57f65479f3d2df797f408 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 5b80040..9dc41a6 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3852,6 +3852,10 @@
       "baseline": "0.31",
       "port-version": 2
     },
+    "liblrc": {
+      "baseline": "1.0.0",
+      "port-version": 1
+    },
     "liblsl": {
       "baseline": "1.16.0",
       "port-version": 0

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/liblrc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/liblrc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/liblrc/vcpkg.json b/ports/liblrc/vcpkg.json
index 16151e9..2509b4f 100644
--- a/ports/liblrc/vcpkg.json
+++ b/ports/liblrc/vcpkg.json
@@ -1,9 +1,9 @@
 {
   "name": "liblrc",
   "version-string": "1.0.0",
-  "license": null,
   "description": "Tools for parsing and playing back LRC lyrics.",
   "homepage": "https://github.com/ywh233/LRC-Tools",
+  "license": null,
   "dependencies": [
     {
       "name": "vcpkg-cmake",

Use the version scheme "version" instead of "version-string" in port "liblrc".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f82fa45df07a446bab57f65479f3d2df797f408 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 5b80040..05c272c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3852,6 +3852,10 @@
       "baseline": "0.31",
       "port-version": 2
     },
+    "liblrc": {
+      "baseline": "1.0.0",
+      "port-version": 0
+    },
     "liblsl": {
       "baseline": "1.16.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 143874878c79404dd49a56c02076a567b316a7a5
new SHA: 7186f5daec8286682c6198f196bdd62a9dbce3f1
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

MonicaLiu0311 · 2022-09-30T02:19:34Z

@rinechran, Thanks for your pr, CI tested failed on many triplets, this is error log.
Please take a look:

CMake Error at CMakeLists.txt:17 (file):
  file COPY cannot set modification time on
  "D:/buildtrees/liblrc/src/8262ee0629-4408e566d5.clean/include/lrc_parser.h":
  File exists.


-- Configuring incomplete, errors occurred!

JackBoosY · 2022-09-30T02:23:21Z

@rinechran, Thanks for your pr, CI tested failed on many triplets, this is error log. Please take a look:
CMake Error at CMakeLists.txt:17 (file):
  file COPY cannot set modification time on
  "D:/buildtrees/liblrc/src/8262ee0629-4408e566d5.clean/include/lrc_parser.h":
  File exists.


-- Configuring incomplete, errors occurred!

~~Please patch to avoid setting timestamp in files which in source path.~~ Please view the latest request changes.

rinechran · 2022-09-30T02:30:34Z

@rinechran, Thanks for your pr, CI tested failed on many triplets, this is error log. Please take a look:
CMake Error at CMakeLists.txt:17 (file):
  file COPY cannot set modification time on
  "D:/buildtrees/liblrc/src/8262ee0629-4408e566d5.clean/include/lrc_parser.h":
  File exists.


-- Configuring incomplete, errors occurred!
Please patch to avoid setting tamestamp in files which in source path.

thank you for your advice

I'll try to work on it this weekend

ports/liblrc/CMakeLists.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 7186f5daec8286682c6198f196bdd62a9dbce3f1
new SHA: 8883c963ad24a5786434f5d94743cb62a901d143
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 8883c963ad24a5786434f5d94743cb62a901d143
new SHA: 6c3e2ffc2e978a4a787ef7c2e111e4a75c832557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

ports/liblrc/CMakeLists.txt

ports/liblrc/portfile.cmake

Co-authored-by: Jack·Boos·Yu <[email protected]>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 6c3e2ffc2e978a4a787ef7c2e111e4a75c832557
new SHA: 631cf031a7e5f6a9872876109b6895603dc75d17
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 631cf031a7e5f6a9872876109b6895603dc75d17
new SHA: a93aba0a682f18848e4dd8edd6468368dc8c25c8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

ports/liblrc/portfile.cmake

ports/liblrc/CMakeLists.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: a93aba0a682f18848e4dd8edd6468368dc8c25c8
new SHA: 3a681cb06d45b17830b0ca94d46155e464f4ffb8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

ports/liblrc/fix-cmake.patch

ports/liblrc/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 3a681cb06d45b17830b0ca94d46155e464f4ffb8
new SHA: 95a607cdc6885eb5cf3d8bc80678e6dc4f7c3b13
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for liblrc have changed but the version was not updated
version: 1.0.0
old SHA: 95a607cdc6885eb5cf3d8bc80678e6dc4f7c3b13
new SHA: e335abcee36904e503939a5636403e7f42affc25
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

[lrc-tool] create a new port

65bda6f

github-actions bot requested changes Sep 28, 2022

View reviewed changes

[lrc-tool] fix portfile.cmake

079b1cb

github-actions bot requested changes Sep 28, 2022

View reviewed changes

[lrc-tool] fix format-manifest portfile.cmake

14ccf46

github-actions bot requested changes Sep 28, 2022

View reviewed changes

[lrc-tool] fix git-tree version

5f75783

github-actions bot previously approved these changes Sep 28, 2022

View reviewed changes

LilyWangLL assigned JonLiu1993 and MonicaLiu0311 Sep 29, 2022

LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 29, 2022

rinechran mentioned this pull request Sep 29, 2022

[New Port Request] <LRC-Tools> #26422

Closed

JackBoosY self-assigned this Sep 30, 2022

MonicaLiu0311 added the requires:author-response label Sep 30, 2022

MonicaLiu0311 changed the title ~~[LRC-Tools] create a new port~~ [liblrc] create a new port Sep 30, 2022

JackBoosY suggested changes Sep 30, 2022

View reviewed changes

ports/liblrc/CMakeLists.txt Outdated Show resolved Hide resolved

[liblrc] remove include copy

5edbeca

rinechran dismissed github-actions[bot]’s stale review via 5edbeca October 9, 2022 07:27

github-actions bot requested changes Oct 9, 2022

View reviewed changes

Update version database

76f6d40

github-actions bot previously approved these changes Oct 9, 2022

View reviewed changes

[liblrc] not support osx

e5d684a

rinechran dismissed github-actions[bot]’s stale review via e5d684a October 9, 2022 07:59

github-actions bot requested changes Oct 9, 2022

View reviewed changes

Update version database

65c87b7

github-actions bot previously approved these changes Oct 9, 2022

View reviewed changes

JackBoosY suggested changes Oct 9, 2022

View reviewed changes

ports/liblrc/CMakeLists.txt Outdated Show resolved Hide resolved

ports/liblrc/CMakeLists.txt Outdated Show resolved Hide resolved

ports/liblrc/portfile.cmake Outdated Show resolved Hide resolved

ports/liblrc/portfile.cmake Show resolved Hide resolved

[liblrc] Apply suggestions from code review

b9025b3

Co-authored-by: Jack·Boos·Yu <[email protected]>

rinechran dismissed github-actions[bot]’s stale review via b9025b3 October 9, 2022 11:02

github-actions bot requested changes Oct 9, 2022

View reviewed changes

[liblrc] fix code review

bc8ffdb

github-actions bot requested changes Oct 9, 2022

View reviewed changes

Update version database

dceda8c

github-actions bot previously approved these changes Oct 9, 2022

View reviewed changes

JackBoosY suggested changes Oct 10, 2022

View reviewed changes

ports/liblrc/portfile.cmake Outdated Show resolved Hide resolved

ports/liblrc/CMakeLists.txt Outdated Show resolved Hide resolved

[liblrc] make CMakeLists.txt to patch

d033049

luncliff dismissed github-actions[bot]’s stale review via d033049 October 10, 2022 03:04

github-actions bot requested changes Oct 10, 2022

View reviewed changes

JackBoosY suggested changes Oct 10, 2022

View reviewed changes

ports/liblrc/fix-cmake.patch Show resolved Hide resolved

ports/liblrc/fix-cmake.patch Outdated Show resolved Hide resolved

ports/liblrc/fix-cmake.patch Outdated Show resolved Hide resolved

ports/liblrc/portfile.cmake Outdated Show resolved Hide resolved

[liblrc] add unofficial

f8e4375

github-actions bot requested changes Oct 10, 2022

View reviewed changes

[liblrc] add unofficial namespace

c6582c2

github-actions bot requested changes Oct 10, 2022

View reviewed changes

[liblrc] Update version database

f010290

github-actions bot approved these changes Oct 10, 2022

View reviewed changes

JackBoosY approved these changes Oct 10, 2022

View reviewed changes

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 10, 2022

vicroms merged commit 72bb4a7 into microsoft:master Oct 13, 2022

rinechran deleted the liblrc branch November 3, 2022 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[liblrc] create a new port #27023

[liblrc] create a new port #27023

rinechran commented Sep 28, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

MonicaLiu0311 commented Sep 30, 2022

JackBoosY commented Sep 30, 2022 •

edited

Loading

rinechran commented Sep 30, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

[liblrc] create a new port #27023

[liblrc] create a new port #27023

Conversation

rinechran commented Sep 28, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

MonicaLiu0311 commented Sep 30, 2022

JackBoosY commented Sep 30, 2022 • edited Loading

rinechran commented Sep 30, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Sep 30, 2022 •

edited

Loading