Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grpc] fix upb library order in pkgconfig #26752

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[grpc] fix upb library order in pkgconfig #26752

merged 1 commit into from
Sep 13, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 10, 2022 •
edited
Loading

Use the same order for upb libraries in the pkgconfig patch as CMake uses.

N/A

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@coryan coryan marked this pull request as ready for review September 10, 2022 18:13
@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Sep 13, 2022
@vicroms vicroms merged commit 9e6aab1 into microsoft:master Sep 13, 2022
@coryan coryan deleted the grpc-fix-upb-order branch September 26, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[grpc] pkg-config files have upb dependencies in the wrong order
3 participants
@coryan @Adela0814 @vicroms