[grpc] pkg-config files have upb dependencies in the wrong order

[coryan]

Describe the bug

Compiling code that uses gRPC via pkg-config produces link errors. The list of -lupb_* options seem to be in the wrong order.

Environment

• OS: Linux
• Compiler: gcc 12

To Reproduce

I am sure this can happen with a smaller repro, but this is how I got it.

1. $HOME/vcpkg-develop/vcpkg install google-cloud-cpp[core,speech]
2. git clone https://github.com/googleapis/google-cloud-cpp
3. cd google-cloud-cpp/google/cloud/speech/quickstart
4. PKG_CONFIG_PATH=$HOME/vcpkg-develop/installed/x64-linux/lib/pkgconfig make
5. See error

/usr/bin/ld: /usr/local/google/home/coryan/vcpkg-develop/installed/x64-linux/lib/pkgconfig/../../lib/libupb.a(decode.c.o): in function `decode_tomsg':
decode.c:(.text+0x1217): undefined reference to `utf8_naive'
/usr/bin/ld: /usr/local/google/home/coryan/vcpkg-develop/installed/x64-linux/lib/pkgconfig/../../lib/libupb.a(decode.c.o): in function `decode_toarray':
decode.c:(.text+0x1a87): undefined reference to `utf8_naive'
collect2: error: ld returned 1 exit status
make: *** [Makefile:36: quickstart] Error 1

Expected behavior

A successful build.

Additional context

When building with CMake the upb dependencies are linked in this order:

libupb_json.a
libupb_textformat.a 
libupb_reflection.a 
libupb.a 
libupb_fastdecode.a 
libupb_utf8_range.a 
libdescriptor_upb_proto.a

Whereas the port for gRPC applies a patch

vcpkg/ports/grpc/portfile.cmake

Line 20 in 8e3595f

00014-pkgconfig-upbdefs.patch

which adds these dependencies to the pkg-config file in a different order:

vcpkg/ports/grpc/00014-pkgconfig-upbdefs.patch

Line 10 in 8e3595f

+ "-lgrpc -laddress_sorting -lre2 -ldescriptor_upb_proto -lupb_fastdecode -lupb_json -lupb_reflection -lupb_textformat -lupb_utf8_range -lupb -lcares -lz"

I think it is a matter of reordering the upb libraries in the pkgconfig patch. I will try to submit a PR to fix this.