Skip to content

[hdf5] Refix msmpi library path in pkgconfig#25089

Merged
vicroms merged 9 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/re-fix-hdf5-mpi-pkgconfig
Jun 15, 2022
Merged

[hdf5] Refix msmpi library path in pkgconfig#25089
vicroms merged 9 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/re-fix-hdf5-mpi-pkgconfig

Conversation

@JackBoosY
Copy link
Contributor

#25036 just fix the build issue, but there is a pkgconfig issue remains:

	lib /nologo /LTCG /out:gdal_d.lib port\*.obj gcore\*.obj alg\*.obj frmts\o\*.obj ogr\ogrsf_frmts\ogrsf_frmts.lib ogr\ogr.lib gnm\*.obj gnm\gnm_frmts\o\*.obj third_party\o\*.obj apps\commonutils.obj apps\gdalinfo_lib.obj apps\gdal_translate_lib.obj apps\gdalwarp_lib.obj apps\ogr2ogr_lib.obj  apps\gdaldem_lib.obj apps\nearblack_lib.obj apps\gdal_grid_lib.obj apps\gdal_rasterize_lib.obj apps\gdalbuildvrt_lib.obj  apps\gdalmdiminfo_lib.obj apps\gdalmdimtranslate_lib.obj   /libpath:D:/installed/x64-windows-static/debug/lib libexpatdMD.lib  D:/installed/x64-windows-static/debug/lib/libpq.lib D:/installed/x64-windows-static/debug/lib/libpgcommon.lib D:/installed/x64-windows-static/debug/lib/libpgport.lib Secur32.lib Shell32.lib Advapi32.lib Crypt32.lib Gdi32.lib /libpath:D:/installed/x64-windows-static/debug/lib libssl.lib libcrypto.lib crypt32.lib ws2_32.lib          /libpath:D:/installed/x64-windows-static/debug/lib jpeg.lib /libpath:D:/installed/x64-windows-static/debug/lib netcdf.lib msmpi.lib libhdf5_hl_D.lib libhdf5_D.lib D:/installed/x64-windows-static/debug/lib/msmpi.lib.lib libszip_D.lib libcurl-d.lib winmm.lib libssl.lib libcrypto.lib ws2_32.lib zlibd.lib advapi32.lib crypt32.lib   D:/installed/x64-windows-static/debug/lib/geotiff_d.lib /libpath:D:/installed/x64-windows-static/debug/lib tiffd.lib zlibd.lib jpeg.lib lzma.lib /libpath:D:/installed/x64-windows-static/debug/lib proj_d.lib ole32.lib shell32.lib sqlite3.lib tiffd.lib jpeg.lib lzma.lib libcurl-d.lib winmm.lib libssl.lib libcrypto.lib ws2_32.lib zlibd.lib advapi32.lib crypt32.lib /libpath:D:/installed/x64-windows-static/debug/lib sqlite3.lib   /libpath:D:/installed/x64-windows-static/debug/lib geos_c.lib geos.lib /libpath:D:/installed/x64-windows-static/debug/lib libhdf5_D.lib D:/installed/x64-windows-static/debug/lib/msmpi.lib.lib libszip_D.lib zlibd.lib      /libpath:D:/installed/x64-windows-static/debug/lib libcurl-d.lib winmm.lib libssl.lib libcrypto.lib ws2_32.lib zlibd.lib advapi32.lib crypt32.lib    legacy_stdio_definitions.lib odbc32.lib odbccp32.lib user32.lib  /libpath:D:/installed/x64-windows-static/debug/lib libpng16d.lib zlibd.lib /libpath:D:/installed/x64-windows-static/debug/lib zlibd.lib   /libpath:D:/installed/x64-windows-static/debug/lib openjp2.lib      /libpath:D:/installed/x64-windows-static/debug/lib lzma.lib /libpath:D:/installed/x64-windows-static/debug/lib zstd.lib    D:/installed/x64-windows-static/debug/lib/iconv.lib D:/installed/x64-windows-static/debug/lib/charset.lib /libpath:D:/installed/x64-windows-static/debug/lib webp.lib       /libpath:D:/installed/x64-windows-static/debug/lib libxml2.lib iconv.lib ws2_32.lib zlibd.lib lzma.lib        ws2_32.lib            kernel32.lib psapi.lib wbemuuid.lib
LINK : fatal error LNK1181: cannot open input file 'D:\installed\x64-windows-static\debug\lib\msmpi.lib.lib'

That's because hdf5 exports the full msmpi path to hdf5.pc:

...
Libs.private:  -lhdf5_D   -lF:/vcpkg/installed/x64-windows-static/debug/lib/msmpi.lib 
Requires.private:  szip zlib
...

#17941 only fixed ompi-c on non-Windows.

Related: #24740

Already tested this with gdal[hdf5]:x64-windows-static.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jun 6, 2022
@JackBoosY
Copy link
Contributor Author

cc @dg0yt for review this PR.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 7, 2022
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a change to avoid giving a bad example for other ports.

@LilyWangLL LilyWangLL removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 9, 2022
@JackBoosY JackBoosY requested a review from ras0219-msft June 13, 2022 08:42
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 14, 2022
@vicroms vicroms merged commit 3d8f781 into microsoft:master Jun 15, 2022
@JackBoosY JackBoosY deleted the dev/jack/re-fix-hdf5-mpi-pkgconfig branch June 16, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants