-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[gazebo] fix gazebo linux dependency #24969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
2edc4ee
fix pkgconf for linux
talregev 66e829c
Fix dependency ogre
aa79376
add port libtar
c4e7c38
remove unnecessary dependencies
64559fd
version
7f59993
Fix freeimage
1f2be0b
Add dependency freeimage
bf46d3b
Re-fix dependency freeimage
fd9b1d9
Add dependency simbody on non-Windows
f9d49bb
Fix dependency simbody
560c29e
Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…
6ce4a85
Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…
db22d08
Fix dependency simdbody and protobuf
27669ab
Fix build type
247eea0
Add dependency opengl for tool gazebo
f1fb243
Add support value !linux temporary
954941b
versopm
f1eb05e
fix pkgconf for linux
talregev cdc066a
Fix dependency ogre
d0cea5b
add port libtar
3e1225f
remove unnecessary dependencies
5a1341a
version
5f7ca2c
Fix freeimage
3d822c4
Add dependency freeimage
4f6e799
Re-fix dependency freeimage
1694553
Add dependency simbody on non-Windows
3f01142
Fix dependency simbody
8e3db63
Fix dependency simdbody and protobuf
d1bba35
Fix build type
2c10644
Add dependency opengl for tool gazebo
513c471
Add support value !linux temporary
5995a55
versopm
5f2216f
fix libtar vcpkg.json file.
talregev 7dc9f7f
Fix gazebo version
talregev ca66961
fix opengl def
talregev 6aa9b5a
Merge branch 'TalR/fix_gazebo' of https://github.com/talregev/vcpkg i…
f8e8342
Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…
487219f
Update
efcda83
Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…
30902c2
Remove supports expression
9c81851
Fix find dependencies using pkgconfig
f44ae79
fix libtar description
talregev 38c0aa1
Fix test and plugin
93128d8
./vcpkg x-add-version --all --overwrite-version
talregev aa120cb
fix freeimage dependency
talregev feb8d37
revert fix freeimage dependency
talregev 278c5f2
Add feature tools, re-generate patches, fix feature tool condition
fbcb869
Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…
489ea98
Merge branch 'master' into TalR/fix_gazebo
JackBoosY 7f42da1
Merge branch 'master' into TalR/fix_gazebo
talregev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,102 +1,141 @@ | ||
| diff --git a/cmake/SearchForStuff.cmake b/cmake/SearchForStuff.cmake | ||
| index 4085b5aaeb..f89ac88333 100644 | ||
| --- a/cmake/SearchForStuff.cmake | ||
| +++ b/cmake/SearchForStuff.cmake | ||
| @@ -179,7 +179,7 @@ if (PKG_CONFIG_FOUND) | ||
| # (needed, at least, for MacOS) | ||
|
|
||
| # Use system installation on UNIX and Apple, and internal copy on Windows | ||
| - if (UNIX OR APPLE) | ||
| + if (true) | ||
| message (STATUS "Using system tinyxml.") | ||
| set (USE_EXTERNAL_TINYXML True) | ||
| elseif(WIN32) | ||
| @@ -225,7 +225,7 @@ if (PKG_CONFIG_FOUND) | ||
| # (needed, at least, for MacOS) | ||
|
|
||
| # Use system installation on UNIX and Apple, and internal copy on Windows | ||
| - if (UNIX OR APPLE) | ||
| + if (true) | ||
| message (STATUS "Using system tinyxml2.") | ||
| set (USE_EXTERNAL_TINYXML2 True) | ||
| elseif(WIN32) | ||
| @@ -513,7 +513,7 @@ if (PKG_CONFIG_FOUND) | ||
| endif () | ||
|
|
||
| if (libavutil_FOUND AND libavformat_FOUND AND libavcodec_FOUND AND | ||
| - libswscale_FOUND) | ||
| + libswscale_FOUND AND FFMPEG_FEATURE) | ||
| set (HAVE_FFMPEG TRUE) | ||
| else () | ||
| set (HAVE_FFMPEG FALSE) | ||
| @@ -538,7 +538,7 @@ if (PKG_CONFIG_FOUND) | ||
| ######################################## | ||
| # Find GNU Triangulation Surface Library | ||
| pkg_check_modules(gts gts) | ||
| - if (gts_FOUND) | ||
| + if (GTS_FEATURE) | ||
| message (STATUS "Looking for GTS - found") | ||
| set (HAVE_GTS TRUE) | ||
| else () | ||
| @@ -551,13 +551,14 @@ if (PKG_CONFIG_FOUND) | ||
| # First and preferred option is to look for bullet standard pkgconfig, | ||
| # so check it first. if it is not present, check for the OSRF | ||
| # custom bullet2.82.pc file | ||
| - pkg_check_modules(BULLET bullet>=2.82) | ||
| + find_package(BULLET CONFIG 2.82) | ||
| if (NOT BULLET_FOUND) | ||
| pkg_check_modules(BULLET bullet2.82>=2.82) | ||
| endif() | ||
|
|
||
| if (BULLET_FOUND) | ||
| set (HAVE_BULLET TRUE) | ||
| + set(BULLET_VERSION ${BULLET_VERSION_STRING}) | ||
| add_definitions( -DLIBBULLET_VERSION=${BULLET_VERSION} ) | ||
| else() | ||
| set (HAVE_BULLET FALSE) | ||
| @@ -572,7 +573,7 @@ if (PKG_CONFIG_FOUND) | ||
| ######################################## | ||
| # Find libusb | ||
| pkg_check_modules(libusb-1.0 libusb-1.0) | ||
| - if (NOT libusb-1.0_FOUND) | ||
| + if (NO_LIBUSB_FEATURE) | ||
| BUILD_WARNING ("libusb-1.0 not found. USB peripherals support will be disabled.") | ||
| set (HAVE_USB OFF CACHE BOOL "HAVE USB" FORCE) | ||
| else() | ||
| @@ -648,7 +649,7 @@ endif () | ||
| ######################################## | ||
| # Find gdal | ||
| include (FindGDAL) | ||
| -if (NOT GDAL_FOUND) | ||
| +if (NO_GDAL_FEATURE) | ||
| message (STATUS "Looking for libgdal - not found") | ||
| BUILD_WARNING ("GDAL not found, Digital elevation terrains support will be disabled.") | ||
| set (HAVE_GDAL OFF CACHE BOOL "HAVE GDAL" FORCE) | ||
| @@ -718,7 +719,7 @@ endif() | ||
| ######################################## | ||
| # Find graphviz | ||
| include (${gazebo_cmake_dir}/FindGraphviz.cmake) | ||
| -if (NOT GRAPHVIZ_FOUND) | ||
| +if (NO_GRAPHVIZ_FEATURE) | ||
| message (STATUS "Looking for libgraphviz-dev - not found") | ||
| BUILD_WARNING ("Graphviz not found, Model editor's schematic view will be disabled.") | ||
| set (HAVE_GRAPHVIZ OFF CACHE BOOL "HAVE GRAPHVIZ" FORCE) | ||
| diff --git a/cmake/gazebo-config.cmake.in b/cmake/gazebo-config.cmake.in | ||
| index b57a90dd76..63ce97095e 100644 | ||
| --- a/cmake/gazebo-config.cmake.in | ||
| +++ b/cmake/gazebo-config.cmake.in | ||
| @@ -99,12 +99,13 @@ list(APPEND @PKG_NAME@_CFLAGS -I${GAZEBO_INSTALL_INCLUDE_DIR}/gazebo-@GAZEBO_MAJ | ||
|
|
||
| if (GAZEBO_HAS_BULLET) | ||
| if (PKG_CONFIG_FOUND) | ||
| - pkg_check_modules(BULLET bullet>=2.82) | ||
| + find_package(BULLET CONFIG 2.82) | ||
| if (NOT BULLET_FOUND) | ||
| pkg_check_modules(BULLET bullet2.82>=2.82) | ||
| endif() | ||
|
|
||
| if (BULLET_FOUND) | ||
| + set(BULLET_VERSION ${BULLET_VERSION_STRING}) | ||
| add_definitions(-DLIBBULLET_VERSION=${BULLET_VERSION}) | ||
| else() | ||
| message(FATAL_ERROR "Error: Bullet > 2.82 not found, please install libbullet2.82-dev.") | ||
| diff --git a/cmake/FindFreeimage.cmake b/cmake/FindFreeimage.cmake | ||
| index a989ec7..2ec8fcc 100644 | ||
| --- a/cmake/FindFreeimage.cmake | ||
| +++ b/cmake/FindFreeimage.cmake | ||
| @@ -33,6 +33,9 @@ if (NOT freeimage_FOUND) | ||
| endif (NOT FREEIMAGE_RUNS) | ||
| endif (NOT freeimage_INCLUDE_DIRS) | ||
|
|
||
| + find_package(freeimage CONFIG REQUIRED) | ||
| + set(freeimage_LIBRARIES freeimage::FreeImage) | ||
| + if (0) | ||
| if (WIN32) | ||
| if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug") | ||
| find_library(freeimage_LIBRARIES FreeImaged) | ||
| @@ -49,4 +52,5 @@ if (NOT freeimage_FOUND) | ||
| message (STATUS " Looking for libfreeimage - found") | ||
| include_directories(${freeimage_INCLUDE_DIRS}) | ||
| endif (NOT freeimage_LIBRARIES) | ||
| + endif() | ||
| endif (NOT freeimage_FOUND) | ||
| diff --git a/cmake/SearchForStuff.cmake b/cmake/SearchForStuff.cmake | ||
| index 9777a46..11864ff 100644 | ||
| --- a/cmake/SearchForStuff.cmake | ||
| +++ b/cmake/SearchForStuff.cmake | ||
| @@ -179,7 +179,7 @@ if (PKG_CONFIG_FOUND) | ||
| # (needed, at least, for MacOS) | ||
|
|
||
| # Use system installation on UNIX and Apple, and internal copy on Windows | ||
| - if (UNIX OR APPLE) | ||
| + if (true) | ||
| message (STATUS "Using system tinyxml.") | ||
| set (USE_EXTERNAL_TINYXML True) | ||
| elseif(WIN32) | ||
| @@ -225,7 +225,7 @@ if (PKG_CONFIG_FOUND) | ||
| # (needed, at least, for MacOS) | ||
|
|
||
| # Use system installation on UNIX and Apple, and internal copy on Windows | ||
| - if (UNIX OR APPLE) | ||
| + if (true) | ||
| message (STATUS "Using system tinyxml2.") | ||
| set (USE_EXTERNAL_TINYXML2 True) | ||
| elseif(WIN32) | ||
| @@ -329,6 +329,7 @@ if (PKG_CONFIG_FOUND) | ||
| ################################################# | ||
| # Find OGRE | ||
|
|
||
| + if (false) | ||
| pkg_check_modules(OGRE-RTShaderSystem | ||
| OGRE-RTShaderSystem>=${MIN_OGRE_VERSION}) | ||
|
|
||
| @@ -375,8 +376,8 @@ if (PKG_CONFIG_FOUND) | ||
| set (OGRE_PLUGINDIR ${_pkgconfig_invoke_result}) | ||
| endif() | ||
| endif() | ||
| - | ||
| - if (NOT OGRE_FOUND) | ||
| + endif() | ||
| + if (true) | ||
| # Workaround for CMake bug https://gitlab.kitware.com/cmake/cmake/issues/17135, | ||
| # that prevents to successfully run a find_package(<package>) call if before there | ||
| # was a failed call to pkg_check_modules(<package> <package>) | ||
| @@ -513,7 +514,7 @@ if (PKG_CONFIG_FOUND) | ||
| endif () | ||
|
|
||
| if (libavutil_FOUND AND libavformat_FOUND AND libavcodec_FOUND AND | ||
| - libswscale_FOUND) | ||
| + libswscale_FOUND AND FFMPEG_FEATURE) | ||
| set (HAVE_FFMPEG TRUE) | ||
| else () | ||
| set (HAVE_FFMPEG FALSE) | ||
| @@ -538,7 +539,7 @@ if (PKG_CONFIG_FOUND) | ||
| ######################################## | ||
| # Find GNU Triangulation Surface Library | ||
| pkg_check_modules(gts gts) | ||
| - if (gts_FOUND) | ||
| + if (GTS_FEATURE) | ||
| message (STATUS "Looking for GTS - found") | ||
| set (HAVE_GTS TRUE) | ||
| else () | ||
| @@ -551,13 +552,14 @@ if (PKG_CONFIG_FOUND) | ||
| # First and preferred option is to look for bullet standard pkgconfig, | ||
| # so check it first. if it is not present, check for the OSRF | ||
| # custom bullet2.82.pc file | ||
| - pkg_check_modules(BULLET bullet>=2.82) | ||
| + find_package(BULLET CONFIG 2.82) | ||
| if (NOT BULLET_FOUND) | ||
| pkg_check_modules(BULLET bullet2.82>=2.82) | ||
| endif() | ||
|
|
||
| if (BULLET_FOUND) | ||
| set (HAVE_BULLET TRUE) | ||
| + set(BULLET_VERSION ${BULLET_VERSION_STRING}) | ||
| add_definitions( -DLIBBULLET_VERSION=${BULLET_VERSION} ) | ||
| else() | ||
| set (HAVE_BULLET FALSE) | ||
| @@ -572,7 +574,7 @@ if (PKG_CONFIG_FOUND) | ||
| ######################################## | ||
| # Find libusb | ||
| pkg_check_modules(libusb-1.0 libusb-1.0) | ||
| - if (NOT libusb-1.0_FOUND) | ||
| + if (NO_LIBUSB_FEATURE) | ||
| BUILD_WARNING ("libusb-1.0 not found. USB peripherals support will be disabled.") | ||
| set (HAVE_USB OFF CACHE BOOL "HAVE USB" FORCE) | ||
| else() | ||
| @@ -648,7 +650,7 @@ endif () | ||
| ######################################## | ||
| # Find gdal | ||
| include (FindGDAL) | ||
| -if (NOT GDAL_FOUND) | ||
| +if (NO_GDAL_FEATURE) | ||
| message (STATUS "Looking for libgdal - not found") | ||
| BUILD_WARNING ("GDAL not found, Digital elevation terrains support will be disabled.") | ||
| set (HAVE_GDAL OFF CACHE BOOL "HAVE GDAL" FORCE) | ||
| @@ -732,7 +734,7 @@ endif() | ||
| ######################################## | ||
| # Find graphviz | ||
| include (${gazebo_cmake_dir}/FindGraphviz.cmake) | ||
| -if (NOT GRAPHVIZ_FOUND) | ||
| +if (NO_GRAPHVIZ_FEATURE) | ||
| message (STATUS "Looking for libgraphviz-dev - not found") | ||
| BUILD_WARNING ("Graphviz not found, Model editor's schematic view will be disabled.") | ||
| set (HAVE_GRAPHVIZ OFF CACHE BOOL "HAVE GRAPHVIZ" FORCE) | ||
| diff --git a/cmake/gazebo-config.cmake.in b/cmake/gazebo-config.cmake.in | ||
| index b57a90d..63ce970 100644 | ||
| --- a/cmake/gazebo-config.cmake.in | ||
| +++ b/cmake/gazebo-config.cmake.in | ||
| @@ -99,12 +99,13 @@ list(APPEND @PKG_NAME@_CFLAGS -I${GAZEBO_INSTALL_INCLUDE_DIR}/gazebo-@GAZEBO_MAJ | ||
|
|
||
| if (GAZEBO_HAS_BULLET) | ||
| if (PKG_CONFIG_FOUND) | ||
| - pkg_check_modules(BULLET bullet>=2.82) | ||
| + find_package(BULLET CONFIG 2.82) | ||
| if (NOT BULLET_FOUND) | ||
| pkg_check_modules(BULLET bullet2.82>=2.82) | ||
| endif() | ||
|
|
||
| if (BULLET_FOUND) | ||
| + set(BULLET_VERSION ${BULLET_VERSION_STRING}) | ||
| add_definitions(-DLIBBULLET_VERSION=${BULLET_VERSION}) | ||
| else() | ||
| message(FATAL_ERROR "Error: Bullet > 2.82 not found, please install libbullet2.82-dev.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| vcpkg_from_git( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| URL https://repo.or.cz/libtar.git | ||
| REF 50dcdd27a33444b974d940ed5f225a2444e5aeba | ||
| ) | ||
|
|
||
| vcpkg_configure_make( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| ) | ||
|
|
||
| vcpkg_install_make() | ||
|
|
||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include" "${CURRENT_PACKAGES_DIR}/debug/share") | ||
|
|
||
| file(INSTALL "${SOURCE_PATH}/COPYRIGHT" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "name": "libtar", | ||
| "version": "1.2.20", | ||
| "description": "TRE is a lightweight, robust, and efficient POSIX compliant regexp matching library with some exciting features such as approximate (fuzzy) matching.", | ||
| "homepage": "https://github.com/laurikari/tre", | ||
| "license": "ICU", | ||
| "supports": "!windows" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "a5593040e54dad7cd9a5b276ce458e6a435fb0b9", | ||
| "version": "1.2.20", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.