[gazebo] fix gazebo linux dependency by talregev · Pull Request #24969 · microsoft/vcpkg

talregev · 2022-05-28T07:55:33Z

Describe the pull request

Depends on:

[ignition-cmake2/ignition-modularscripts/ignition-common3] Add options, support pkgconfig and fix usage for common3-graph #25021
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

talregev · 2022-05-28T08:14:33Z

error logs from ci:
failure logs for x64-linux.zip

Please help me to solve these errors.

talregev · 2022-05-29T15:17:21Z

@dg0yt It not find OGRE library (and few other) in linux. How to inject the:
find_package(OGRE CONFIG REQUIRED) into to the CMakeLists.txt ?

JackBoosY · 2022-05-30T08:23:00Z

CMake Error at CMakeLists.txt:196 (string):
  string sub-command REPLACE requires at least four arguments.

line 193:

set(OGRE_RESOURCE_PATH ${OGRE_PLUGINDIR})
# Seems that OGRE_PLUGINDIR can end in a newline, which will cause problems when
# we pass it to the compiler later.
string(REPLACE "\n" "" OGRE_RESOURCE_PATH ${OGRE_RESOURCE_PATH})

talregev · 2022-05-30T08:39:54Z

CMake Error at CMakeLists.txt:196 (string):
  string sub-command REPLACE requires at least four arguments.

line 193:

set(OGRE_RESOURCE_PATH ${OGRE_PLUGINDIR})
# Seems that OGRE_PLUGINDIR can end in a newline, which will cause problems when
# we pass it to the compiler later.
string(REPLACE "\n" "" OGRE_RESOURCE_PATH ${OGRE_RESOURCE_PATH})

This error is due that it not find the orge lib plugin dir

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: fdd2f6d0cf11bafd2b0b3ba2513fc2060fc90aeb
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

JackBoosY · 2022-05-30T08:58:01Z

Please do not update version record until the fix is correct.

JackBoosY · 2022-05-30T09:09:41Z

This port requres libtar in non-Windows.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: e92c3ca1ef1cd3e18e626ceec2560b54276f169c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: 6f1307abb14934d599e7fe38167c90946c453984
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: 8c2227dddb4562ad149103b51628731402c3f1ab
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: 143c9f1d2e768b7efcaf3101a8af0586fb4511d8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 2022-01-20#2
old SHA: 0575eb88760d8605617cd01db94b58444afccccc
new SHA: f5027e77c637cc69dfb87c13839e73143ea593a8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

JackBoosY · 2022-05-31T07:22:39Z

port ignition-common3 has usage issue:

CMake Error at /home/work/vcpkg/scripts/buildsystems/vcpkg.cmake:573 (_add_executable):
  Target "sample" links to target "GTS::GTS" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:45 (add_executable)


CMake Error at /home/work/vcpkg/scripts/buildsystems/vcpkg.cmake:573 (_add_executable):
  Target "sample" links to target "FreeImage::FreeImage" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:45 (add_executable)


CMake Error at /home/work/vcpkg/scripts/buildsystems/vcpkg.cmake:573 (_add_executable):
  Target "sample" links to target "TINYXML2::TINYXML2" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:45 (add_executable)

for ignition-common3-graphics.

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libtar/vcpkg.json

Valid values for the license field can be found in the documentation

dg0yt · 2022-07-16T19:41:21Z

I looked at the gazebo dependencies and at the gazebo CMake code. I must say that I have no desire to deal with it. Too much bad code on the way.

talregev · 2022-07-16T19:53:38Z

I looked at the gazebo dependencies and at the gazebo CMake code. I must say that I have no desire to deal with it. Too much bad code on the way.

I understand. Thank you for your time that you looking up, and also for your advice.

JackBoosY · 2022-07-20T02:54:29Z

@JackBoosY It not orge usage.

It is.
-lboost-thread-mt and -lfreeimage comes from ogre's pkgconfig file:
In debug/lib/pkgconfig/OGRE.pc:

Libs: -L"${libdir}" -L"${plugindir}" -lOgreMainStatic  -lpthread -lboost-thread-mt -lfreeimage

link list from command line:

-lOgreTerrainStatic
-lOgrePagingStatic
-lOgreMainStatic
-lpthread
-lboost-thread-mt
-lfreeimage
...

-lboost-thread-mt should be -lboost_thread, and -lfreeimage should be -lFreeImaged.

talregev · 2022-07-20T04:52:16Z

@JackBoosY It not orge usage.

It is. -lboost-thread-mt and -lfreeimage comes from ogre's pkgconfig file: In debug/lib/pkgconfig/OGRE.pc:
Libs: -L"${libdir}" -L"${plugindir}" -lOgreMainStatic  -lpthread -lboost-thread-mt -lfreeimage
link list from command line:
-lOgreTerrainStatic
-lOgrePagingStatic
-lOgreMainStatic
-lpthread
-lboost-thread-mt
-lfreeimage
...
-lboost-thread-mt should be -lboost_thread, and -lfreeimage should be -lFreeImaged.

I didn't know that. Thank you for let me know.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 11.11.0
old SHA: cb1797db605abbde18f8925fb96144daf28331a4
new SHA: 5b371c6736101c009f35972adfe3b5dfa2ac8871
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libtar/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-07-20T10:00:34Z

Needs to fix dependency gdal.

dg0yt · 2022-07-20T10:51:47Z

Needs to fix dependency gdal.

You need to turn gazebo's include(FindGDAL) into a proper find_package(GDAL).
https://github.com/osrf/gazebo/blob/323fc1c58178bcbc5076e97bf7e6ff736c21cc7d/cmake/SearchForStuff.cmake#L656

And maybe take care of all other include (Find...), too.

JackBoosY · 2022-07-21T02:36:54Z

Also need to fix dependency qwt.

…/fix_gazebo

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 11.11.0
old SHA: cb1797db605abbde18f8925fb96144daf28331a4
new SHA: 5b371c6736101c009f35972adfe3b5dfa2ac8871
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libtar/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 11.11.0
old SHA: cb1797db605abbde18f8925fb96144daf28331a4
new SHA: 5b371c6736101c009f35972adfe3b5dfa2ac8871
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libtar/vcpkg.json

Valid values for the license field can be found in the documentation

talregev · 2022-08-22T19:29:40Z

Fix conflicts

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gazebo have changed but the version was not updated
version: 11.11.0
old SHA: cb1797db605abbde18f8925fb96144daf28331a4
new SHA: 5b371c6736101c009f35972adfe3b5dfa2ac8871
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libtar/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-09-16T08:32:25Z

Sorry but I currently don't have the energy to continue fixing this PR, any volunteers to take over this PR?

talregev · 2022-10-02T17:59:14Z

@luncliff Are you ready for next challenge?
Maybe compile the new gazebo: ignite gazebo? That is different repo:
https://github.com/gazebosim/gz-sim

You can open a new PR, and I will close this one.

LilyWangLL · 2022-10-14T07:41:21Z

Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again.

LilyWangLL · 2022-11-25T09:11:48Z

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.

fix pkgconf for linux

2edc4ee

github-actions bot approved these changes May 28, 2022

View reviewed changes

FrankXie05 assigned JackBoosY May 30, 2022

JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label May 30, 2022

Fix dependency ogre

66e829c

github-actions bot requested changes May 30, 2022

View reviewed changes

JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:port-bug The issue is with a library, which is something the port should already support labels May 30, 2022

JackBoosY added 4 commits May 30, 2022 02:49

add port libtar

aa79376

remove unnecessary dependencies

c4e7c38

version

64559fd

Fix freeimage

7f59993

github-actions bot requested changes May 30, 2022

View reviewed changes

Add dependency freeimage

1f2be0b

github-actions bot requested changes May 30, 2022

View reviewed changes

Re-fix dependency freeimage

bf46d3b

github-actions bot requested changes May 31, 2022

View reviewed changes

Add dependency simbody on non-Windows

fd9b1d9

github-actions bot requested changes May 31, 2022

View reviewed changes

Fix dependency simbody

f9d49bb

github-actions bot requested changes May 31, 2022

View reviewed changes

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 31, 2022

JackBoosY mentioned this pull request Jun 1, 2022

[ignition-cmake2/ignition-modularscripts/ignition-common3] Add options, support pkgconfig and fix usage for common3-graph #25021

Merged

talregev force-pushed the TalR/fix_gazebo branch from 65ff88b to feb8d37 Compare July 16, 2022 19:17

github-actions bot previously approved these changes Jul 16, 2022

View reviewed changes

JackBoosY mentioned this pull request Jul 20, 2022

[ogre] Fix pkgconfig #25883

Merged

Add feature tools, re-generate patches, fix feature tool condition

278c5f2

JackBoosY dismissed github-actions[bot]’s stale review via 278c5f2 July 20, 2022 09:52

github-actions bot requested changes Jul 20, 2022

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…

fbcb869

…/fix_gazebo

github-actions bot requested changes Jul 21, 2022

View reviewed changes

Merge branch 'master' into TalR/fix_gazebo

489ea98

github-actions bot requested changes Aug 4, 2022

View reviewed changes

Merge branch 'master' into TalR/fix_gazebo

7f42da1

github-actions bot requested changes Aug 22, 2022

View reviewed changes

JackBoosY assigned LilyWangLL and unassigned JackBoosY Oct 14, 2022

LilyWangLL marked this pull request as draft October 14, 2022 07:41

LilyWangLL closed this Nov 25, 2022

talregev mentioned this pull request Mar 25, 2023

[Help needed][gazebo] Fix gazebo dependencies #30424

Closed

10 tasks

talregev deleted the TalR/fix_gazebo branch March 10, 2024 22:22

Conversation

talregev commented May 28, 2022 • edited by JackBoosY Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

talregev commented May 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented May 29, 2022

Uh oh!

JackBoosY commented May 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented May 30, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented May 30, 2022

Uh oh!

JackBoosY commented May 30, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt commented Jul 16, 2022

Uh oh!

talregev commented Jul 16, 2022

Uh oh!

JackBoosY commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talregev commented Jul 20, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Jul 20, 2022

Uh oh!

dg0yt commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Jul 21, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev commented Aug 22, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Sep 16, 2022

Uh oh!

talregev commented Oct 2, 2022

Uh oh!

LilyWangLL commented Oct 14, 2022

Uh oh!

LilyWangLL commented Nov 25, 2022

talregev commented May 28, 2022 •

edited by JackBoosY

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

talregev commented May 28, 2022 •

edited

Loading

JackBoosY commented May 30, 2022 •

edited

Loading

JackBoosY commented May 31, 2022 •

edited

Loading

JackBoosY commented Jul 20, 2022 •

edited

Loading

dg0yt commented Jul 20, 2022 •

edited

Loading