Skip to content

[wxwidgets] Fix absolute paths#24261

Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
dg0yt:wxwidgets-abspaths
Apr 21, 2022
Merged

[wxwidgets] Fix absolute paths#24261
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
dg0yt:wxwidgets-abspaths

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 20, 2022

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 20, 2022

The downside of file(GLOB ...): You don't notice wrong paths.

CC @autoantwort.

@dg0yt dg0yt force-pushed the wxwidgets-abspaths branch from 46c5aca to 5f09734 Compare April 20, 2022 07:40
@FrankXie05 FrankXie05 self-assigned this Apr 20, 2022
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 20, 2022
@autoantwort
Copy link
Contributor

You don't notice wrong paths.

Because of that I always use a custom build vcpkg-tool with microsoft/vcpkg-tool#172

@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 21, 2022
Copy link
Contributor

@talregev talregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run correctly on the ci

@strega-nil-ms
Copy link
Contributor

Thank you @dg0yt!

@strega-nil-ms strega-nil-ms merged commit 9234b34 into microsoft:master Apr 21, 2022
@dg0yt dg0yt deleted the wxwidgets-abspaths branch December 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants