[wxwidgets] Validate and fix by dg0yt · Pull Request #24047 · microsoft/vcpkg

dg0yt · 2022-04-08T19:19:49Z

What does your PR fix?
- Major change: No mixing of debug and release variables.
  (For windows, I had to rely on build logs including CMake --trace-expand in vpckg-ci-wxwidgets. Manual review welcome.)
  - [wxWidgets] static triplet only debug/release library mixup #16545
  - [wxwidgets] With VS2019 solution generated by cmake in debug mode, release version of wx is used #18066)
- Major change: No absolute paths.
  - [wxwidgets][Linux] libs without full path in wx-config, cause linkage errors. #18298
  - [wxwidgets] Linux linkage binary and flags problem #24038
- Fixed mingw. (Tricking FindwxWidgets.cmake into unix mode via wrapper.)
  - [wxWidgets: x64-mingw-static] build failure #13747
  - wxwidgets:x64-mingw-dynamic Build error; cant find wxrc.exe #21883
- Updated and verified usage.
  - [wxwidgets] error "No Target! You should use wx-config program for compilation flags!" #17072
- Fixed dependencies for libjpeg-turbo and curl.
Out of scope for this PR:
- wxrc probably won't work properly in cross builds.
  - Solution might be a (non-GUI) host build with wxUSE_XRC.
  - Mitigation is a user-side host dependency.
- Apart from the known dependency on system GTK3 on Linux, there seem to be additonal unmanaged dependencies (SDL, OpenGL, cairo (related: wxwidgets[core]:x64-linux build failure #7931), ...).
- Version 3.1.6 is available upstream.
  To be done in separate PR.
Which triplets are supported/not supported? Have you updated the CI baseline?

all, no (no CI testing for x64-linux due to GTK 3 dependency)
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/wxwidgets/vcpkg.json b/ports/wxwidgets/vcpkg.json
index 435348b..089e02e 100644
--- a/ports/wxwidgets/vcpkg.json
+++ b/ports/wxwidgets/vcpkg.json
@@ -25,7 +25,7 @@
     "zlib"
   ],
   "features": {
-    "example" : {
+    "example": {
       "description": "Example source code and CMake project"
     }
   }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d72783cb3aeddfd667861caef1060e54ca6fa7a9 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 4dc8f8d..f7f406b 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7498,7 +7498,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..22f10f4 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a8eb52c74cddc858d6a59187bedb666456e83cf9",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

talregev · 2022-04-08T19:47:14Z

Follow this fix. Thank you.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..8cca2d4 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b3f82f8e52d357a2fd6346a06fa49765a0784bb6",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..ea5554f 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9b75b56e40db43bb78a31348bc14580fb4f19784",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..f2f1495 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b8aa5c1b09f21f3336f6c10dfc7ebef626dcd4f8",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..c78d7a6 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "97db7c1b0d34158952ecdc6db6ce6a0aae282256",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..2519621 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "faa68115d2c002efc172b9082a75ba93b80ce00a",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bd1ef2df46303989eeb048eb7aa9b816aa46365e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index c7016f8..6b904ab 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..797d132 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "ed6660583c3bd29abfd0421bf6f9d9a42069f1f4",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

dg0yt · 2022-04-10T13:49:47Z

In the current state of the PR (9adb008), the port behaves much better:

Major change: No mixing of debug and release variables.
(For windows, I had to rely on build logs including CMake --trace-expand in vpckg-ci-wxwidgets. Manual review welcome.)
- [wxWidgets] static triplet only debug/release library mixup #16545
- [wxwidgets] With VS2019 solution generated by cmake in debug mode, release version of wx is used #18066)
Major change: No absolute paths.
...almost. I see now that tools/wxwidgets/wx-config is still a symlink. But for CMake (unix mode), the wrapper doesn't use that location.
- [wxwidgets][Linux] libs without full path in wx-config, cause linkage errors. #18298
- [wxwidgets] Linux linkage binary and flags problem #24038
Updated and verified usage.
- [wxwidgets] error "No Target! You should use wx-config program for compilation flags!" #17072

There are still some shortcomings:

mingw doesn't work yet (related: [wxWidgets: x64-mingw-static] build failure #13747, wxwidgets:x64-mingw-dynamic Build error; cant find wxrc.exe #21883).
I have to merge some more changes from another computer to fix the build.
And I probably need to trick FindwxWidgets.cmake into unix mode.
wxrc probably won't work properly in cross builds.
Solution might be a (non-GUI) host build. (A non-GUI build could also work for CI on Linux.)
Apart from the known dependency on system GTK3 on Linux, there seem to be additonal unmanaged dependencies (SDL, OpenGL, cairo (related: wxwidgets[core]:x64-linux build failure #7931), lzma, ...).
version 3.1.6 is available upstream. Not sure if this helps wrt GTK4.

All open issues for wxwidgets:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+wxwidgets+in%3Atitle

dg0yt · 2022-04-10T13:54:27Z

ports/wxwidgets/fix-libs-export.patch

We might make it an error if there is something else than NOT, CONFIG:DEBUG, LINK_ONLY, to catch future changes.

ports/wxwidgets/vcpkg-cmake-wrapper.cmake

talregev · 2022-04-10T18:52:55Z

Should I test it too? Is ready for test?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout f6af75acc923c833a5620943e3fc7d5e4930f0df -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 630a0f7..0ca1fdc 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7502,7 +7502,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 10
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..8a0b7ce 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "78544fc3c99af9bc945de55497e778692a8ccaf5",
+      "version-semver": "3.1.5",
+      "port-version": 10
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

Split original patch. Restore missing appending in the end. Drop libs (generator expression) which don't match build type.

ports/wxwidgets/portfile.cmake

Thomas1664 · 2022-04-15T11:22:18Z

One question about examples:
WxWidgets installs examples by default although you marked it a feature:

wxwidgets:x64-windows:/share/wxwidgets/example/CMakeLists.txt
wxwidgets:x64-windows:/share/wxwidgets/example/popup.cpp
wxwidgets:x64-windows:/share/wxwidgets/example/sample.xpm

Is this intended?

dg0yt · 2022-04-15T12:20:17Z

WxWidgets installs examples by default

Not by default but in CI. wxwidgets[examples] is a dependency of the vcpkg-ci-wxwidgets test port.
(This whole work was test-first, and it is likely to break again if I reduce test coverage.)

strega-nil-ms

LGTM apart from that

strega-nil-ms · 2022-04-15T18:14:16Z

ports/wxwidgets/CMakeLists.txt

@@ -0,0 +1,21 @@
+cmake_minimum_required(VERSION 3.7)


I don't love this being named top level CMakeLists.txt; I'd prefer it to be in an example folder.

Also, I need to test this with the windows.cmake CMAKE_CROSSCOMPILING change, since I noticed find_package(wxWidgets) is broken by CMAKE_CROSSCOMPILING

I don't love this being named top level CMakeLists.txt; I'd prefer it to be in an example folder.

Okay.

Also, I need to test this with the windows.cmake CMAKE_CROSSCOMPILING change, since I noticed find_package(wxWidgets) is broken by CMAKE_CROSSCOMPILING

Which change do you refer to? Which breakage?

AFAICS the CMake find module doesn't support win32 mode with CMAKE_CROSSCOMPILING:
https://github.com/Kitware/CMake/blob/6453bd046ef23798c64333042d76851f15eff2fc/Modules/FindwxWidgets.cmake#L221-L225

(Mingw was added only 5 days ago. For MSVC, apart from fixing upstream, we could try to hack it the opposite way I did for mingw.)

mmh, it looks like this is a vcpkg thing; CMAKE_CROSSCOMPILING is never set on Windows targeting Windows. (it's not set right now either, but we're going to be setting it in windows.cmake in the future)

strega-nil-ms · 2022-04-15T20:41:31Z

ports/wxwidgets/vcpkg-cmake-wrapper.cmake

+if(MINGW AND NOT CMAKE_CROSSCOMPILING)
+    # Force FindwxWidgets.cmake unix mode, matching mingw install layout
+    set(_vcpkg_wxwidgets_fake_crosscompiling 1)
+    set(CMAKE_CROSSCOMPILING 1)
+endif()


Suggested change

if(MINGW AND NOT CMAKE_CROSSCOMPILING)

# Force FindwxWidgets.cmake unix mode, matching mingw install layout

set(_vcpkg_wxwidgets_fake_crosscompiling 1)

set(CMAKE_CROSSCOMPILING 1)

endif()

if(MINGW AND NOT CMAKE_CROSSCOMPILING)

# Force FindwxWidgets.cmake unix mode, matching mingw install layout

set(_vcpkg_wxwidgets_backup_crosscompiling "${CMAKE_CROSSCOMPILING}")

set(CMAKE_CROSSCOMPILING 1)

endif()

if(WIN32 AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows")

set(_vcpkg_wxwidgets_backup_crosscompiling "${CMAKE_CROSSCOMPILING}")

set(CMAKE_CROSSCOMPILING 0)

endif()

@strega-nil-ms I applied this with modifications.

strega-nil-ms · 2022-04-15T20:43:10Z

ports/wxwidgets/vcpkg-cmake-wrapper.cmake

+if(MINGW)
+    if(_vcpkg_wxwidgets_fake_crosscompiling)
+        unset(CMAKE_CROSSCOMPILING)
+        unset(_vcpkg_wxwidgets_fake_crosscompiling)
+    endif()
+elseif(WIN32 AND "@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static")


Suggested change

if(MINGW)

if(_vcpkg_wxwidgets_fake_crosscompiling)

unset(CMAKE_CROSSCOMPILING)

unset(_vcpkg_wxwidgets_fake_crosscompiling)

endif()

elseif(WIN32 AND "@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static")

if(DEFINED _vcpkg_wxwidgets_backup_crosscompiling)

set(CMAKE_CROSSCOMPILING "${_vcpkg_wxwidgets_backup_crosscompiling}")

unset(_vcpkg_wxwidgets_backup_crosscompiling)

endif()

if(WIN32 AND NOT MINGW AND "@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static")

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/cmake-user/vcpkg.json
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json

Valid values for the license field can be found in the documentation

talregev

Working on the ci and wsl2.

strega-nil-ms · 2022-04-18T17:55:55Z

Thanks!

autoantwort · 2022-04-19T10:45:55Z

The lib now contains absolute paths:
vcpkg/packages/wxwidgets_arm64-osx/tools/wxwidgets/wx-config:

ldlibs_base="/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libz.a -lwxregexu-3.1 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libiconv.tbd -framework CoreFoundation -framework Security -framework Carbon -framework Cocoa -framework IOKit -framework QuartzCore"
ldlibs_core="-lwx_baseu-3.1 /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libjpeg.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libpng.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libz.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libtiff.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/liblzma.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libjpeg.a /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libz.a -lm  -framework AudioToolbox -framework WebKit "
ldlibs_xml="-lwx_baseu-3.1 /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/lib/libexpat.a"

dg0yt · 2022-04-19T10:56:16Z

I can take a look tonight. wx-config is used by FindwxWidgets.cmake so it must be fixed.

github-actions bot requested changes Apr 8, 2022

View reviewed changes

dg0yt force-pushed the wxwidgets branch from 0c85d4f to 5381054 Compare April 9, 2022 15:08

github-actions bot requested changes Apr 9, 2022

View reviewed changes

github-actions bot requested changes Apr 10, 2022

View reviewed changes

dg0yt force-pushed the wxwidgets branch from b5011a6 to 4e5c425 Compare April 10, 2022 12:27

github-actions bot requested changes Apr 10, 2022

View reviewed changes

dg0yt force-pushed the wxwidgets branch from 4e5c425 to 9adb008 Compare April 10, 2022 13:02

github-actions bot requested changes Apr 10, 2022

View reviewed changes

dg0yt mentioned this pull request Apr 10, 2022

[wxwidgets] error "No Target! You should use wx-config program for compilation flags!" #17072

Closed

dg0yt mentioned this pull request Apr 10, 2022

[wxwidgets] Linux linkage binary and flags problem #24038

Closed

dg0yt commented Apr 10, 2022

View reviewed changes

ports/wxwidgets/vcpkg-cmake-wrapper.cmake Outdated Show resolved Hide resolved

JonLiu1993 assigned LilyWangLL Apr 11, 2022

JackBoosY self-assigned this Apr 11, 2022

JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Apr 11, 2022

dg0yt force-pushed the wxwidgets branch from 9adb008 to 0fcb5b6 Compare April 11, 2022 05:42

github-actions bot requested changes Apr 11, 2022

View reviewed changes

dg0yt added 8 commits April 11, 2022 19:56

Add wxwidgets example and test port

97430f9

Fix library processing for export

63a5cd7

Split original patch. Restore missing appending in the end. Drop libs (generator expression) which don't match build type.

Make wx-config relocatable

040809a

Rewrite wrapper

5f84aa3

Add missing libjpeg-turbo dependency

f809593

Fixup wxrc

0b35857

Update usage

4d43b8c

Validate release/debug consistency

39375c2

Thomas1664 reviewed Apr 15, 2022

View reviewed changes

ports/wxwidgets/portfile.cmake Show resolved Hide resolved

strega-nil-ms suggested changes Apr 15, 2022

View reviewed changes

strega-nil-ms added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Apr 15, 2022

Merge master into wxwidgets

f12bb57

github-actions bot approved these changes Apr 17, 2022

View reviewed changes

dg0yt marked this pull request as draft April 17, 2022 11:52

dg0yt added 3 commits April 17, 2022 15:48

CR request: Move CMakelists.txt to example dir

16cc13b

CR requests: Revise wrapper

78307e5

Update versions

a4ad20c

github-actions bot approved these changes Apr 17, 2022

View reviewed changes

dg0yt marked this pull request as ready for review April 17, 2022 19:34

JackBoosY requested a review from strega-nil-ms April 18, 2022 09:05

JackBoosY removed the requires:author-response label Apr 18, 2022

talregev approved these changes Apr 18, 2022

View reviewed changes

strega-nil-ms approved these changes Apr 18, 2022

View reviewed changes

strega-nil-ms merged commit 48d15f4 into microsoft:master Apr 18, 2022

dg0yt deleted the wxwidgets branch April 19, 2022 10:56

dg0yt mentioned this pull request Apr 20, 2022

[wxwidgets] Fix absolute paths #24261

Merged

LilyWangLL mentioned this pull request May 18, 2022

[wxwidgets][Linux] libs without full path in wx-config, cause linkage errors. #18298

Closed

7Redacted mentioned this pull request May 21, 2022

wxWidgets build failure - dlls only copied in release profile CMAKE builds, debug profile builds unable to run (Duplicate of 21827) #24851

Closed

generic-pers0n mentioned this pull request Oct 15, 2022

[Experimental] vcpkg update + remove custom wxWidgets port tenacityteam/vcpkg#1

Closed

Conversation

dg0yt commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev commented Apr 8, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt commented Apr 10, 2022

Uh oh!

dg0yt Apr 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

talregev commented Apr 10, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Thomas1664 commented Apr 15, 2022

Uh oh!

dg0yt commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dg0yt Apr 15, 2022

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 15, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt Apr 17, 2022

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

talregev left a comment

Choose a reason for hiding this comment

dg0yt commented Apr 8, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

dg0yt commented Apr 15, 2022 •

edited

Loading

strega-nil-ms Apr 15, 2022 •

edited

Loading

strega-nil-ms Apr 15, 2022 •

edited

Loading

strega-nil-ms Apr 15, 2022 •

edited

Loading

autoantwort commented Apr 19, 2022 •

edited

Loading