[chartdir] use versioned download link

[cd-pkwan]

The original download link is a generic link that points to the latest version of the software. The download content can change from time to time, and this will break the SHA512 hash in the port. This update change the download link to a link that points to the real file with version number, which will not change. This makes the port more stable.

[strega-nil-ms]

@cd-pkwan I assume you're the author, since the website has been changed to mention vcpkg; would it be possible for you to do the same for the macOS and Linux versions?

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for chartdir but no changes to version or port version.
-- Version: 7.0.0#3
-- Old SHA: 2b4bad1eb46439cbd63295d8120f03966c52d162
-- New SHA: 7b689d64616cb407757ebc0e4427b39c77d72bd6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

[ghost]

All CLA requirements met.

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/chartdir/vcpkg.json

Valid values for the license field can be found in the documentation

[JonLiu1993]

@cd-pkwan ,Thanks for your pr, could you please sign in CLA first?

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/chartdir/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

I removed the skips from 671db8a from ci.baseline.txt , so if we get versioned links for MacOS and Linux we can finally start testing chardir regularly :)

[cd-pkwan]

Updated to use versioned download link for macOS, Linux x86 and Linux x64.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 38ea7762498f4040b51d17bef9218e755934f3cb -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/chartdir.json b/versions/c-/chartdir.json
index a8aeb8a..6dc299d 100644
--- a/versions/c-/chartdir.json
+++ b/versions/c-/chartdir.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "470db0162f8e6a30ded91a22d8611e1a2fee2aac",
+      "git-tree": "1cc0eca76a11a651585beeefe4eae9abcd557fa0",
       "version": "7.0.0",
       "port-version": 4
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/chartdir/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

Building package chartdir[core]:x64-windows-static...
-- Note: chartdir only supports dynamic library linkage. Building dynamic library.
CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:61 (message):
  Refusing to build unexpected dynamic library against the static CRT.

      If this is desired, please configure your triplet to directly request this configuration.
Call Stack (most recent call first):
  ports/chartdir/portfile.cmake:1 (vcpkg_check_linkage)
  scripts/ports.cmake:145 (include)

Should we add "supports": "!staticcrt" to vcpkg.json?

The other platforms are broken because:

if(TRIPLET_SYSTEM_ARCH MATCHES "arm" OR VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore" OR VCPKG_LIBRARY_LINKAGE STREQUAL static)

    set(VCPKG_POLICY_EMPTY_PACKAGE enabled)

is entered, so SOURCE_PATH does not get set, so

file(COPY "${SOURCE_PATH}/LICENSE.TXT" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright")

fails.

Proposal:

From 7d16e8044a677537c24564cce898ebdedeed3772 Mon Sep 17 00:00:00 2001
From: Billy Robert O'Neal III <bion@microsoft.com>
Date: Tue, 29 Mar 2022 10:52:41 -0700
Subject: [PATCH] Guard with supports rather than making the package empty.

---
 ports/chartdir/portfile.cmake | 6 +-----
 ports/chartdir/vcpkg.json     | 3 ++-
 versions/c-/chartdir.json     | 2 +-
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/ports/chartdir/portfile.cmake b/ports/chartdir/portfile.cmake
index bfeb10699..b263588f3 100644
--- a/ports/chartdir/portfile.cmake
+++ b/ports/chartdir/portfile.cmake
@@ -1,10 +1,6 @@
 vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)
 
-if(TRIPLET_SYSTEM_ARCH MATCHES "arm" OR VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore" OR VCPKG_LIBRARY_LINKAGE STREQUAL static)
-
-    set(VCPKG_POLICY_EMPTY_PACKAGE enabled)
-
-elseif(VCPKG_TARGET_IS_WINDOWS)
+if(VCPKG_TARGET_IS_WINDOWS)
 
     vcpkg_download_distfile(ARCHIVE_FILE
         URLS "https://www.advsofteng.com/vcpkg/chartdir_cpp_win_7.0.0.zip"
diff --git a/ports/chartdir/vcpkg.json b/ports/chartdir/vcpkg.json
index 425a2ca91..b6a1cfa0a 100644
--- a/ports/chartdir/vcpkg.json
+++ b/ports/chartdir/vcpkg.json
@@ -3,5 +3,6 @@
   "version": "7.0.0",
   "port-version": 4,
   "description": "ChartDirector is a powerful chart component for creating professional looking charts for web and windows applications.",
-  "homepage": "https://www.advsofteng.com/"
+  "homepage": "https://www.advsofteng.com/",
+  "supports": "!staticcrt & !arm & !uwp"
 }
diff --git a/versions/c-/chartdir.json b/versions/c-/chartdir.json
index a8aeb8aab..d7186fafa 100644
--- a/versions/c-/chartdir.json
+++ b/versions/c-/chartdir.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "470db0162f8e6a30ded91a22d8611e1a2fee2aac",
+      "git-tree": "6b1b1029aa38c2a698a4cd6e3cfa7104a3580baf",
       "version": "7.0.0",
       "port-version": 4
     },
-- 
2.35.1.windows.2

[cd-pkwan]

My understanding of x64-windows-static is that the package should work with the static C runtime. In this case, the chartdir, though being a DLL, should work with the CRT static library. I often create projects in Visual Studio that use the /MT option to link with the static C runtime and it works normally. Does the x64-windows-static actually test if the package itself is a static library?

[BillyONeal]

My understanding of x64-windows-static is that the package should work with the static C runtime.

We have blocks around attempting to use DLLs with the static CRT because it gives each DLL their own copy of the CRT. So the DLL interface can't contain std::string* or FILE* or otherwise interact with any CRT entity, which substantially all libraries we have seen are unprepared to deal with.

Does the x64-windows-static actually test if the package itself is a static library?

I don't know if we have an explicit post-build check for it but if a port does otherwise that port is extremely badly behaved. People who pick static want single-exe deployment.

[BillyONeal]

We have blocks around attempting to use DLLs with the static CRT because it gives each DLL their own copy of the CRT. So the DLL interface can't contain std::string* or FILE* or otherwise interact with any CRT entity, which substantially all libraries we have seen are unprepared to deal with.

That said it looks like bchartdir.h indicates that this is intentionally done at the moment.

I think you can just do:

# ChartDirector's DLL interface only contains primitive types, so it is CRT agnostic.
if("${VCPKG_LIBRARY_LINKAGE}" STREQUAL "static")
    message(STATUS "Note: ${PORT} only supports dynamic library linkage. Building dynamic library.")
    set(VCPKG_LIBRARY_LINKAGE dynamic)
endif()

or similar in portfile.cmake rather than using vcpkg_check_linkage. vcpkg_check_linkage is the 99% case but you're kinda juggling razor blades :)

[JonLiu1993]

@cd-pkwan, Could you consider @BillyONeal's suggestion?

[cd-pkwan]

Yes, I will try to include @BillyONeal's suggestion.

Actually I have never used vcpkg. One day my client told me our software ChartDirector is available in vcpkg but the checksum is incorrect due to we updated our release file. That's why I am here. I will download vcpkg and try it myself to make sure any I would not break something by modifying the package script.

[BillyONeal]

@cd-pkwan Thanks so much for helping fix the situation :D

vcpkg requires exact SHA matches to deliver on the "no changes means no changes" policy. Building the same code 5 years later should produce the same output.

[JonLiu1993]

@cd-pkwan ,Can you please resolve the conflicts against master?

[cd-pkwan]

I am embarassed to say that I am not familiar with vcpkg or github. I think the conflict is resolved, but there is still a checksum problem with versions/c-/chartdir.json. Can someone help to fix this problem as well?

[BillyONeal]

The SHA listed there is the git-tree of the portfile directory. You can fix it with (assuming https://github.com/microsoft/vcpkg/ is your origin and your stuff is the current branch):

git merge origin/master
git checkout origin/master -- versions
.\vcpkg x-add-version chartdir
git commit -am "Update version database."

I just ran this for you.

[BillyONeal]

I am embarassed to say that

No need to be embarrassed! In a perfect world we would give you one button to just fix this...

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/chartdir/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

Thanks for the improvement!