[gmp] Switch sources on windows away from SMP fork.

[Neumann-A]

No description provided.

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/gmp/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/gmp/vcpkg.json

Valid values for the license field can be found in the documentation

[ras0219-msft]

This is an awesome improvement.

[LilyWangLL]

@Neumann-A There are regression error on CI pipeline:

if (target_option=k; case ${target_option-} in ?) ;; *) echo "am__make_running_with_option: internal error: invalid" "target option '${target_option-}' specified" >&2; exit 1;; esac; has_opt=no; sane_makeflags=$MAKEFLAGS; if { if test -z '1'; then false; elif test -n 'x86_64-pc-msys'; then true; elif test -n '4.3' && test -n '/d/buildtrees/gmp/x64-windows-dbg'; then true; else false; fi; }; then sane_makeflags=$MFLAGS; else case $MAKEFLAGS in *\\[\ \	]*) bs=\\; sane_makeflags=`printf '%s\n' "$MAKEFLAGS" | sed "s/$bs$bs[$bs $bs	]*//g"`;; esac; fi; skip_next=no; strip_trailopt () { flg=`printf '%s\n' "$flg" | sed "s/$1.*$//"`; }; for flg in $sane_makeflags; do test $skip_next = yes && { skip_next=no; continue; }; case $flg in *=*|--*) continue;; -*I) strip_trailopt 'I'; skip_next=yes;; -*I?*) strip_trailopt 'I';; -*O) strip_trailopt 'O'; skip_next=yes;; -*O?*) strip_trailopt 'O';; -*l) strip_trailopt 'l'; skip_next=yes;; -*l?*) strip_trailopt 'l';; -[dEDm]) skip_next=yes;; -[JT]) skip_next=yes;; esac; case $flg in *$target_option*) has_opt=yes; break;; esac; done; test $has_opt = yes); then \
get_ui.obj : error LNK2005: __gmpz_get_ui already defined in bin_ui.obj
neg.obj : error LNK2005: __gmpz_neg already defined in bin_ui.obj
stronglucas.obj : error LNK2005: __gmpz_perfect_square_p already defined in perfsqr.obj
add.obj : error LNK2005: __gmpn_add already defined in add.obj
add_1.obj : error LNK2005: __gmpn_add_1 already defined in add_ui.obj
sub.obj : error LNK2005: __gmpn_sub already defined in sub.obj
sub_1.obj : error LNK2005: __gmpn_sub_1 already defined in sub.obj
neg.obj : error LNK2005: __gmpn_neg already defined in sub.obj
cmp.obj : error LNK2005: __gmpn_cmp already defined in cmp.obj
zero_p.obj : error LNK2005: __gmpn_zero_p already defined in combit.obj
LINK : fatal error LNK1104: cannot open file '.libs/libgmp-3.dll.def'

[Neumann-A]

• x64_uwp: fails because gmp builds some code generators which won't work on uwp. Needs host dep on gmp itself and manual copying of the generators.

• x64_windows/x86_windows: Strange duplicated symbols which I can only reproduce on x86 (for me x64 build successfully). I couldn't find an obvious reason in the sources so somebody with more knowledge than me needs to look at it.

[Neumann-A]

related https://www.mail-archive.com/gmp-bugs@gmplib.org/msg00423.html

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5a8a1dfff8e2dffd4c8cc2d1fc0da379ffd18b25 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/g-/gmp.json b/versions/g-/gmp.json
index f6ad9ad..6e7b3ca 100644
--- a/versions/g-/gmp.json
+++ b/versions/g-/gmp.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "66917e3a6421c994cf676763cd48c30f8117c8ec",
+      "git-tree": "d252d4fbdebdfeff6c7d17087e9f66cdc3a0c07e",
       "version": "6.2.1",
       "port-version": 9
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/gmp/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/gmp/vcpkg.json
• ports/mpc/vcpkg.json
• ports/nettle/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/gmp/vcpkg.json
• ports/mpc/vcpkg.json
• ports/nettle/vcpkg.json

Valid values for the license field can be found in the documentation

[ras0219-msft]

LGTM once the manual-tools directory is renamed to tools. If the concern is that users might be confused, I'm fine with adding more subdirectories underneath tools/${PORT}/... to clarify

[ras0219-msft]

Suggested change

	list(TRANSFORM tool_names PREPEND "${CURRENT_HOST_INSTALLED_DIR}/manual-tools/${PORT}/")
	list(TRANSFORM tool_names PREPEND "${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}/")

I don't think this is special enough to need a new top-level directory "manual-tools"

[Neumann-A]

Manual-tools already exists in e.g. the vcpkg-tool-python2 port and it is intended that those tools dont get automatically added to CMAKE_PROGRAM_PATH.

[wrobelda]

FYI, you seem to have left remove_gmpd.patch behind.