Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Fix uninitialized values #23710

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

JonLiu1993
Copy link
Member

Describe the pull request

Add patch to apply this change HowardHinnant/date@a74eb1a
fix the error:

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/home/travis/build/acgetchell/CDT-plusplus/build/src/cdt+0x642ce1) in date::get_tzdb_list()

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 22, 2022
@JonLiu1993 JonLiu1993 marked this pull request as ready for review March 23, 2022 01:59
@JonLiu1993 JonLiu1993 assigned FrankXie05 and unassigned JackBoosY Mar 23, 2022
@FrankXie05
Copy link
Contributor

@acgetchell At present, the upstream has accepted this change. We prefer to submit an issue upstream to release a new version to update this change. We will not merge this PR, but it can be used temporarily to avoid similar problems.

@FrankXie05 FrankXie05 added depends:upstream-changes Waiting on a change to the upstream project and removed depends:upstream-changes Waiting on a change to the upstream project labels Apr 1, 2022
@FrankXie05
Copy link
Contributor

The modified content does not destroy the code logic, only initialized some functions, there is no need to wait for a new version to be released, this pull request can be accepted.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/date/vcpkg.json

Valid values for the license field can be found in the documentation

@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 1143d75 into microsoft:master Apr 5, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/date branch April 6, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date] Update port to fix use-of-uninitialized-value
4 participants