Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Update port to fix use-of-uninitialized-value #23637

Closed
acgetchell opened this issue Mar 18, 2022 · 3 comments · Fixed by #23710
Closed

[date] Update port to fix use-of-uninitialized-value #23637

acgetchell opened this issue Mar 18, 2022 · 3 comments · Fixed by #23710
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@acgetchell
Copy link

Describe the bug
The current port for [date] when running on MSAN produces:

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/home/travis/build/acgetchell/CDT-plusplus/build/src/cdt+0x642ce1) in date::get_tzdb_list()

This was fixed in:

HowardHinnant/date@a74eb1a

Please revise the port to include these changes.

Environment

  • OS: Ubuntu 20.04
  • Compiler: clang-13

To Reproduce
Steps to reproduce the behavior:

  1. ./vcpkg install date
  2. Run MSAN

Expected behavior
No uninitialized variable use.

Failure logs

https://app.travis-ci.com/github/acgetchell/CDT-plusplus/jobs/563927674#L1376

Additional context

To run MSAN in Travis, I use:

https://github.com/acgetchell/CDT-plusplus/blob/develop/cmake/Sanitizers.cmake#L69

And then build, e.g.:

https://github.com/acgetchell/CDT-plusplus/blob/develop/.travis.yml#L83

It would probably be pretty easy to translate to GHA, I just haven't done so.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 21, 2022
@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-update The issue is with a library, which is requesting update new revision labels Mar 22, 2022
@JonLiu1993
Copy link
Member

@acgetchell, thanks for posting this question, I found out that upstream hasn't released a stable version for a long time, I added a patch as you suggested to apply the changes from HowardHinnant/date@a74eb1a , if the upstream releases the stable version, I will update the version immediately, I have submitted a pr to fix this, Could you test this pr on your local machine? Thanks!

@acgetchell
Copy link
Author

Done. I applied the changes locally and recompiled (arm64-osx) with no errors or warnings.

@JonLiu1993
Copy link
Member

@acgetchell , I have commit a issue for date upstream, I'll update the port as soon as date releases a new version

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants