[Bullet3] Remove platform restrictions#23673
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Mar 21, 2022
Merged
Conversation
|
|
Bullet claims to support all platforms. ARM works on android and UWP seems to be taken into consideration. Vcpkg's restrictions are historical and seem to date back to when the CI was unable to properly test all platforms.
JonLiu1993
changed the title
JonLiu1993
added
the
category:port-feature
JonLiu1993
approved these changes
Mar 21, 2022
JonLiu1993
changed the title
JonLiu1993
added
the
info:needs-maintainer-attention
Member
|
Looks good, thank you! |
Contributor
Author
|
Both patches added here have now been merged in bullet 3.22 |
Member
Awesome, thank you <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Bullet claims to support all platforms. ARM works on android and UWP seems to be taken into consideration.
Vcpkg's restrictions are historical and seem to date back to when the CI was unable to properly test all platforms.
Added restrictions for Windows ARM and UWP: #9663
Was unable to test arm on linux (and android, I assume) and added more restrictions: #21108
Removed the restriction for osx (M1 architecture, I assume) but didn't check others: #22729
Test status:
UWP:
arm64-windows:
Android: Built and used in a project (x64, x86, arm7, arm8)
arm-linux: Built on a raspberry pi 4
arm64-linux: Built on a raspberry pi 4
x86-windows: Built on a windows 10 x64 machine
arm-windows: Built on a windows 10 x64 machine
What does your PR fix?
Fixes building Bullet for android platform - all currently supported architectures.
Which triplets are supported/not supported? Have you updated the CI baseline?
All platforms are supposed to be supported
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes