Skip to content

[bullet3] Add support for OSX arm triplet#21108

Merged
dan-shaw merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/21091
Nov 2, 2021
Merged

[bullet3] Add support for OSX arm triplet#21108
dan-shaw merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/21091

Conversation

@JackBoosY
Copy link
Contributor

bullet3 can be built successfully on arm64-osx, enable this triplet.
Cannot test arm64-linux because there is no arm-linux machine.

Fixes #21091.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 1, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/bullet3/portfile.cmake

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 2, 2021
@dan-shaw dan-shaw merged commit 0de4f9f into microsoft:master Nov 2, 2021
@JackBoosY JackBoosY deleted the dev/jack/21091 branch November 3, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bullet3] build failure Mac M1 / arm64

3 participants