[VCPKG] Adding support for COS binary caching#23538
[VCPKG] Adding support for COS binary caching#23538strega-nil-ms merged 1 commit intomicrosoft:masterfrom day253:add-cos-tools
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
The tools contained in this file are required by vcpkg instead of ports, please do not put them here.
|
Any reason to add this tool? |
|
Depends on microsoft/vcpkg-tool#435. |
JackBoosY
added
category:vcpkg-feature
Because of the code conflict. Depends on microsoft/vcpkg-tool#476. |
|
@JackBoosY I found vcpkg will not make the directly downloaded binary executable. The tar package will preserve the right permission. I am not really familiar with codebase. Where is the right place to add this function? I think the nuget.exe have the same problem. |
PhoebeHui
changed the title
|
@day253 In vcpkg-tool side. You can also find the other tools in https://github.com/microsoft/vcpkg-tool/blob/3425b0930a8c67e1280fd8ce39b457a81b5a27e6/src/vcpkg/tools.cpp |
The upstream PR microsoft/vcpkg-tool#476 has been merged. Can you please approve this PR？ |
JackBoosY
removed
the
depends:different-pr
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JackBoosY All check have passed. |
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Can you please have a test with this tools?
Another PR or this time？I have to find a way to test this tool. |
|
The utest of vcpkg-tool just test the parse of the config file. https://github.com/microsoft/vcpkg-tool/blob/3425b0930a/src/vcpkg-test/tools.cpp |
I open an issue track this test problem. |
Just test this locally would be good. |
We have deployed this tool in our production enviroment. So this PR will not break current codebase. |
JackBoosY
added
the
info:needs-maintainer-attention
|
LGTM! Thanks :) |
|
The SHA-512 hash used for the Windows executable appears to now be incorrect. I don't know if the file changed recently on the server or if perhaps the hash was always incorrect. |
4 participants
Describe the pull request
What does your PR fix?
Adding support for COS binary cachingdepends on microsoft/vcpkg-tool#435
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
No