Adding support for COS binary caching #476
Merged
ras0219-msft merged 4 commits intomicrosoft:mainfrom Apr 12, 2022
day253:add-cos-supply
Merged
Adding support for COS binary caching #476ras0219-msft merged 4 commits intomicrosoft:mainfrom day253:add-cos-supply
ras0219-msft merged 4 commits intomicrosoft:mainfrom
day253:add-cos-supply
Conversation
This was referenced Mar 31, 2022
vicroms
requested changes
Mar 31, 2022
Member
vicroms
left a comment
vicroms
left a comment
There was a problem hiding this comment.
I would like to see localizable strings for error messages.
Contributor
Author
All resolved |
ras0219-msft
requested changes
Apr 1, 2022
Collaborator
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Contributor
Author
|
looking forward to your reply. |
vicroms
approved these changes
Apr 8, 2022
Contributor
Author
|
ras0219-msft
approved these changes
Apr 12, 2022
Collaborator
|
LGTM, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Object Storage (COS) is a distributed storage service launched by Tencent Cloud. It is readily compatible with AWS S3 APIs, allowing direct access to community tools and plugins with ease. (refer to https://intl.cloud.tencent.com/products/cos)
This PR is to enable vcpkg users to use COS for binary caching.
#435
Any advice for the unitest? I tested the feature locally.