[x264] enable cross-compile settings propagation for arm64-linux

[sylvain-prevost]

Describe the pull request

• What does your PR fix?

  Fixes [x264] arm64 cross-compile settings are ignored. #22899
  (follow-up of [x264] enable cross-compile settings propagation for arm64-linux. #22900)
  Result of X-compilation successfully tested on Jetson nano device.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  !(arm & windows), No

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[JackBoosY]

Depends on #23525.

[JackBoosY]

/azp run

[JackBoosY]

Close and reopen this PR to re-trigger the ci test.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

cc @dg0yt for review this.

[dg0yt]

Disclaimer: I don't use this port.

[sylvain-prevost]

Currently fails on PR formatting due to 'version-string'.
If 'version' is used instead of 'version-string', it passes the checks but then it does not match the dot-version definition.
Any clue/guidance ?

[dg0yt]

Currently fails on PR formatting due to 'version-string'.
If 'version' is used instead of 'version-string', it passes the checks but then it does not match the dot-version definition.
Any clue/guidance ?

Created #23585.

[JackBoosY]

Can you please rerun the command ./vcpkg format-manifest ports/x264/vcpkg.json then check the changes?

[sylvain-prevost]

Hi @JackBoosY , sorry for the delay, I was away for a while.
Running the mentioned command does not generate any local change.

λ vcpkg format-manifest ports/x264/vcpkg.json
Succeeded in formatting the manifest files.

[sylvain-prevost]

issue #23766 is not anymore present, however the version-string issue is still there :(

When I created the PR, I used the command

vcpkg x-add-version x264

and the output was:

Use the version scheme "version" instead of "version-string" in port "x264".
Use --skip-version-format-check to disable this check.

Thereafter I used the suggested flag to be able to generate the version & baseline files.
Since then there is this PR Suggestion CI build error that is there.

If I replace 'version-string' by 'version' then it passes the check, but that would be invalid since the value of the version is: ''164-5db6aa6cab1b146" and this is not a dot-version.

[JackBoosY]

Oh I totally lost track with this PR, sorry.

[strega-nil-ms]

I don't know enough about this to say - I'm marking this as requires:discussion so we can talk with the team on thursday. Thanks for the PR!

[strega-nil-ms]

This seems wrong; can you please post the CC= line from buildtrees/x264/arm64-linux-dbg/config.mak and the VCPKG_DETECTED_CMAKE_C_COMPILER line from buildtrees/x264/cmake-vars-arm64-linux-dbg.cmake.log, before the change that you've made? That should let us isolate where the failure is.

[sylvain-prevost]

Hi @LilyWangLL ,

1. To be able to generate the config.mak file, the first thing is to enable option --disable-asm for linux & arm64.

2. Once done, here are the requested lines:

from buildtrees/x264/[target]-rel/config.mak:
CC=gcc

from buildtrees/x264/cmake-vars-[target]-rel.cmake.log:
set(VCPKG_DETECTED_CMAKE_C_COMPILER "/root/builds/jetson-nano-cross-compile-assets/toolchains/toolchain-gcc-cross-linaro-7.5.0/bin/aarch64-linux-gnu-gcc")

Just in case, to reduce ping-pong, I'm adding in attachment the corresponding files.

config.mak.log

cmake-vars-jetson-rel.cmake.log

[sylvain-prevost]

And the triplet file I'm using for my target (jetson nano), cross-compiled on WSL2 Ubuntu 20.04:

set (VCPKG_TARGET_ARCHITECTURE arm64)
set (VCPKG_CRT_LINKAGE dynamic)
set (VCPKG_LIBRARY_LINKAGE static)
set (VCPKG_CMAKE_SYSTEM_NAME Linux)
set (VCPKG_CMAKE_SYSTEM_VERSION Tegra)

set (VCPKG_MAKE_BUILD_TRIPLET --host=aarch64-linux-gnu)

if (DEFINED ENV{GSTREAMER_FOR_DEEPSTREAM})
# gstreamer is required to be built as shared library (for nVidia deepstream), along with few other libraries.
if (${PORT} MATCHES "gstreamer|pango|cairo|glib|pcre|libffi")
set (VCPKG_LIBRARY_LINKAGE dynamic)
endif()
endif()

set (VCPKG_CHAINLOAD_TOOLCHAIN_FILE ${CMAKE_CURRENT_LIST_DIR}/../toolchains/aarch64_linux_jetson.cmake)

[sylvain-prevost]

@strega-nil-ms , requested info is available.

[BillyONeal]

As in #22331 , ideally we would be setting all the right tools to the right bits (via CC, AR, etc.) rather than trying to coax x264's build scripts into detecting the right bits themselves.

Based on https://github.com/mirror/x264/blob/master/configure#L557 it looks like you need:

• CC
• STRINGS
• AR
• RANLIB
• PKGCONFIG (??? it seems like this runs on the host so we don't understand why it is cross-prefix'd)
• STRIP (but we don't enable stripping so this one may not matter)

[BillyONeal]

This condition is probably wrong: Why is cross compiling for arm64 different than any other cross compiling?

[BillyONeal]

Based on https://github.com/mirror/x264/blob/master/configure#L557 it looks like you need:

To clarify, you need to get these values from vcpkg_cmake_get_vars and set those environment variables as consumed by that configure script. Start with CC, AR, and RANLIB since with those it will probably just work.

[JackBoosY]

Convert this PR to draft since there is no progress.

[JackBoosY]

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.