Skip to content

[x264] enable cross-compile settings propagation for arm64-linux.#22900

Closed
sylvain-prevost wants to merge 3 commits intomicrosoft:masterfrom
sylvain-prevost:x264_xcompile
Closed

[x264] enable cross-compile settings propagation for arm64-linux.#22900
sylvain-prevost wants to merge 3 commits intomicrosoft:masterfrom
sylvain-prevost:x264_xcompile

Conversation

@sylvain-prevost
Copy link
Contributor

@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Feb 3, 2022
@sylvain-prevost sylvain-prevost marked this pull request as ready for review February 3, 2022 10:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/x264/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@BillyONeal
Copy link
Member

This edit is substantially identical to #22331

@strega-nil-ms
Copy link
Contributor

This edit is substantially identical to #22331

I'd say here that we should merge #22331, and then this change will be unneeded.

@sylvain-prevost
Copy link
Contributor Author

Just reviewed #22331 and tested locally. Indeed It does solves the '--host' problem.
However the --cross-prefix problem still remains (this is expected by x264 ). I'll close this PR and wait for #22331 to be merged. Then I'll re-test and submit PR for x264 to cross-compile properly with user-specified toolchain.
(see line 557 of x264 configure-file: https://github.com/mirror/x264/blob/master/configure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x264] arm64 cross-compile settings are ignored.

5 participants